Re: [PATCHv3] perf tools: Add struct ordered_events_buffer layer

2018-09-06 Thread Stephane Eranian
On Thu, Sep 6, 2018 at 6:29 AM Jiri Olsa wrote: > > On Mon, Sep 03, 2018 at 07:37:56PM -0700, Stephane Eranian wrote: > > SNIP > > > > > I think the code is correct now for the issue related to uninitialized > > pointer. > > But there is still one problem I found stressing the code with > > max_

Re: [PATCHv3] perf tools: Add struct ordered_events_buffer layer

2018-09-06 Thread Jiri Olsa
On Mon, Sep 03, 2018 at 07:37:56PM -0700, Stephane Eranian wrote: SNIP > > I think the code is correct now for the issue related to uninitialized > pointer. > But there is still one problem I found stressing the code with max_alloc_size. > The way the following is written: > >if (!list

Re: [PATCHv3] perf tools: Add struct ordered_events_buffer layer

2018-09-03 Thread Stephane Eranian
Jiri, On Sun, Sep 2, 2018 at 7:47 AM Jiri Olsa wrote: > > On Mon, Aug 27, 2018 at 07:05:43PM +0200, Jiri Olsa wrote: > > On Mon, Aug 27, 2018 at 08:24:56AM -0700, Stephane Eranian wrote: > > > > SNIP > > > > > > - /* First entry is abused to maintain the to_free list. > > > > */ >

Re: [PATCHv3] perf tools: Add struct ordered_events_buffer layer

2018-09-02 Thread Jiri Olsa
On Mon, Aug 27, 2018 at 07:05:43PM +0200, Jiri Olsa wrote: > On Mon, Aug 27, 2018 at 08:24:56AM -0700, Stephane Eranian wrote: > > SNIP > > > > - /* First entry is abused to maintain the to_free list. */ > > > - oe->buffer_idx = 2; > > > - new = oe->buffe

[PATCHv3] perf tools: Add struct ordered_events_buffer layer

2018-08-27 Thread Jiri Olsa
On Mon, Aug 27, 2018 at 08:24:56AM -0700, Stephane Eranian wrote: SNIP > > - /* First entry is abused to maintain the to_free list. */ > > - oe->buffer_idx = 2; > > - new = oe->buffer + 1; > > + oe->buffer_idx = 1; > > + new =