Re: [Linaro-mm-sig] [PATCHv2 3/4] staging: android: ion: Add an ioctl for ABI checking

2016-09-02 Thread Laura Abbott
On 09/02/2016 02:33 PM, Arnd Bergmann wrote: On Friday, September 2, 2016 1:33:44 PM CEST Laura Abbott wrote: On 09/02/2016 02:02 AM, Arnd Bergmann wrote: On Thursday, September 1, 2016 3:40:43 PM CEST Laura Abbott wrote: --- a/drivers/staging/android/ion/ion-ioctl.c +++ b/drivers/staging/and

Re: [Linaro-mm-sig] [PATCHv2 3/4] staging: android: ion: Add an ioctl for ABI checking

2016-09-02 Thread Arnd Bergmann
On Friday, September 2, 2016 1:33:44 PM CEST Laura Abbott wrote: > On 09/02/2016 02:02 AM, Arnd Bergmann wrote: > > On Thursday, September 1, 2016 3:40:43 PM CEST Laura Abbott wrote: > > > >> --- a/drivers/staging/android/ion/ion-ioctl.c > >> +++ b/drivers/staging/android/ion/ion-ioctl.c > >> @@ -2

Re: [Linaro-mm-sig] [PATCHv2 3/4] staging: android: ion: Add an ioctl for ABI checking

2016-09-02 Thread Laura Abbott
On 09/02/2016 02:02 AM, Arnd Bergmann wrote: On Thursday, September 1, 2016 3:40:43 PM CEST Laura Abbott wrote: --- a/drivers/staging/android/ion/ion-ioctl.c +++ b/drivers/staging/android/ion/ion-ioctl.c @@ -22,6 +22,29 @@ #include "ion_priv.h" #include "compat_ion.h" +union ion_ioctl_arg {

Re: [PATCHv2 3/4] staging: android: ion: Add an ioctl for ABI checking

2016-09-02 Thread Laura Abbott
On 09/01/2016 11:10 PM, Greg Kroah-Hartman wrote: On Thu, Sep 01, 2016 at 03:40:43PM -0700, Laura Abbott wrote: The current Ion ioctls lack a good way to tell what ioctls are available. Introduce an ioctl to give an ABI version. This way when the ABI inevitably gets screwed up userspace will ha

Re: [Linaro-mm-sig] [PATCHv2 3/4] staging: android: ion: Add an ioctl for ABI checking

2016-09-02 Thread Arnd Bergmann
On Thursday, September 1, 2016 3:40:43 PM CEST Laura Abbott wrote: > --- a/drivers/staging/android/ion/ion-ioctl.c > +++ b/drivers/staging/android/ion/ion-ioctl.c > @@ -22,6 +22,29 @@ > #include "ion_priv.h" > #include "compat_ion.h" > > +union ion_ioctl_arg { > + struct ion_fd_data fd; >

Re: [PATCHv2 3/4] staging: android: ion: Add an ioctl for ABI checking

2016-09-01 Thread Greg Kroah-Hartman
On Thu, Sep 01, 2016 at 03:40:43PM -0700, Laura Abbott wrote: > > The current Ion ioctls lack a good way to tell what ioctls are > available. Introduce an ioctl to give an ABI version. This way when the > ABI inevitably gets screwed up userspace will have a way to tell what > version of the screw

[PATCHv2 3/4] staging: android: ion: Add an ioctl for ABI checking

2016-09-01 Thread Laura Abbott
The current Ion ioctls lack a good way to tell what ioctls are available. Introduce an ioctl to give an ABI version. This way when the ABI inevitably gets screwed up userspace will have a way to tell what version of the screw up is available. Signed-off-by: Laura Abbott --- drivers/staging/andr