Re: [PATCHv2 2/4] ACPI / LPSS: custom power domain for LPSS

2014-05-23 Thread Heikki Krogerus
On Fri, May 23, 2014 at 03:10:08PM +0200, Rafael J. Wysocki wrote: > On Friday, May 23, 2014 03:30:53 PM Heikki Krogerus wrote: > > On Thu, May 22, 2014 at 01:28:16AM +0200, Rafael J. Wysocki wrote: > > > On Wednesday, May 21, 2014 01:52:58 PM Heikki Krogerus wrote: > > > > On Wed, May 21, 2014 at

Re: [PATCHv2 2/4] ACPI / LPSS: custom power domain for LPSS

2014-05-23 Thread Rafael J. Wysocki
On Friday, May 23, 2014 03:30:53 PM Heikki Krogerus wrote: > On Thu, May 22, 2014 at 01:28:16AM +0200, Rafael J. Wysocki wrote: > > On Wednesday, May 21, 2014 01:52:58 PM Heikki Krogerus wrote: > > > On Wed, May 21, 2014 at 01:01:31PM +0200, Rafael J. Wysocki wrote: > > > > On Wednesday, May 21, 20

Re: [PATCHv2 2/4] ACPI / LPSS: custom power domain for LPSS

2014-05-23 Thread Heikki Krogerus
On Thu, May 22, 2014 at 01:28:16AM +0200, Rafael J. Wysocki wrote: > On Wednesday, May 21, 2014 01:52:58 PM Heikki Krogerus wrote: > > On Wed, May 21, 2014 at 01:01:31PM +0200, Rafael J. Wysocki wrote: > > > On Wednesday, May 21, 2014 01:05:11 PM Heikki Krogerus wrote: > > > > On Tue, May 20, 2014

Re: [PATCHv2 2/4] ACPI / LPSS: custom power domain for LPSS

2014-05-21 Thread Rafael J. Wysocki
On Wednesday, May 21, 2014 01:52:58 PM Heikki Krogerus wrote: > On Wed, May 21, 2014 at 01:01:31PM +0200, Rafael J. Wysocki wrote: > > On Wednesday, May 21, 2014 01:05:11 PM Heikki Krogerus wrote: > > > On Tue, May 20, 2014 at 11:33:09PM +0200, Rafael J. Wysocki wrote: > > > > First, is the 10 ms s

Re: [PATCHv2 2/4] ACPI / LPSS: custom power domain for LPSS

2014-05-21 Thread Heikki Krogerus
On Wed, May 21, 2014 at 01:01:31PM +0200, Rafael J. Wysocki wrote: > On Wednesday, May 21, 2014 01:05:11 PM Heikki Krogerus wrote: > > On Tue, May 20, 2014 at 11:33:09PM +0200, Rafael J. Wysocki wrote: > > > First, is the 10 ms sleep really necessary? I'd expect the AML to take > > > care of > >

Re: [PATCHv2 2/4] ACPI / LPSS: custom power domain for LPSS

2014-05-21 Thread Rafael J. Wysocki
On Wednesday, May 21, 2014 01:05:11 PM Heikki Krogerus wrote: > Hi Rafael, > > On Tue, May 20, 2014 at 11:33:09PM +0200, Rafael J. Wysocki wrote: > > > +#ifdef CONFIG_PM > > > > It would be good to add a kerneldoc explaining what's being saved here and > > why. > > OK. > > > > +static void acp

Re: [PATCHv2 2/4] ACPI / LPSS: custom power domain for LPSS

2014-05-21 Thread Heikki Krogerus
Hi Rafael, On Tue, May 20, 2014 at 11:33:09PM +0200, Rafael J. Wysocki wrote: > > +#ifdef CONFIG_PM > > It would be good to add a kerneldoc explaining what's being saved here and > why. OK. > > +static void acpi_lpss_save_ctx(struct device *dev) > > +{ > > + struct lpss_private_data *pdata =

Re: [PATCHv2 2/4] ACPI / LPSS: custom power domain for LPSS

2014-05-20 Thread Rafael J. Wysocki
On Thursday, May 15, 2014 04:40:24 PM Heikki Krogerus wrote: > A power domain where we save the context of the additional > LPSS registers. We need to do this or all LPSS devices are > left in reset state when resuming from D3 on some Baytrails. > The devices with the fractional clock divider also

[PATCHv2 2/4] ACPI / LPSS: custom power domain for LPSS

2014-05-15 Thread Heikki Krogerus
A power domain where we save the context of the additional LPSS registers. We need to do this or all LPSS devices are left in reset state when resuming from D3 on some Baytrails. The devices with the fractional clock divider also have zeros for N and M values after resuming unless they are reset.