Re: [PATCHv2 10/10] zram: add dynamic device add/remove functionality

2015-04-22 Thread Minchan Kim
On Thu, Apr 23, 2015 at 01:23:00PM +0900, Sergey Senozhatsky wrote: > On (04/23/15 12:06), Minchan Kim wrote: > > > +Example: > > > + cat /sys/class/zram-control/zram_add > > > > Why do we put zram-contol there rather than /sys/block/zram > > that's what clsss_register() does. > > [..] > > > >

Re: [PATCHv2 10/10] zram: add dynamic device add/remove functionality

2015-04-22 Thread Sergey Senozhatsky
On (04/23/15 12:06), Minchan Kim wrote: > > +Example: > > + cat /sys/class/zram-control/zram_add > > Why do we put zram-contol there rather than /sys/block/zram that's what clsss_register() does. [..] > > @@ -1168,8 +1172,15 @@ static int zram_add(int device_id) > > Why do zram_add need devi

Re: [PATCHv2 10/10] zram: add dynamic device add/remove functionality

2015-04-22 Thread Minchan Kim
On Thu, Apr 23, 2015 at 12:06 PM, Minchan Kim wrote: > On Thu, Apr 16, 2015 at 08:55:56PM +0900, Sergey Senozhatsky wrote: >> We currently don't support on-demand device creation. The one and only way >> to have N zram devices is to specify num_devices module parameter (default >> value 1). That m

Re: [PATCHv2 10/10] zram: add dynamic device add/remove functionality

2015-04-22 Thread Minchan Kim
On Thu, Apr 16, 2015 at 08:55:56PM +0900, Sergey Senozhatsky wrote: > We currently don't support on-demand device creation. The one and only way > to have N zram devices is to specify num_devices module parameter (default > value 1). That means that if, for some reason, at some point, user wants >

[PATCHv2 10/10] zram: add dynamic device add/remove functionality

2015-04-16 Thread Sergey Senozhatsky
We currently don't support on-demand device creation. The one and only way to have N zram devices is to specify num_devices module parameter (default value 1). That means that if, for some reason, at some point, user wants to have N + 1 devies he/she must umount all the existing devices, unload the