Re: [PATCHv2 1/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-25 Thread Shubhrajyoti
On Tuesday 25 September 2012 04:25 PM, Felipe Balbi wrote: >> +.buf = &addr >> > + }, >> > + {/* setup read ptr */ > should this comment be /* read date */ ?? yes missed that . will update -- To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: [PATCHv2 1/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-25 Thread Felipe Balbi
On Tue, Sep 25, 2012 at 04:03:38PM +0530, Shubhrajyoti D wrote: > Convert the struct i2c_msg initialization to C99 format. This makes > maintaining and editing the code simpler. Also helps once other fields > like transferred are added in future. > > Signed-off-by: Shubhrajyoti D > --- > drivers

[PATCHv2 1/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-25 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-ds1672.c | 26 ++ 1 files changed, 22 inser

[PATCHv2 1/7] rtc: Convert struct i2c_msg initialization to C99 format

2012-09-24 Thread Shubhrajyoti D
Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Signed-off-by: Shubhrajyoti D --- drivers/rtc/rtc-ds1672.c | 26 ++ 1 files changed, 22 inser