On (04/23/15 11:38), Minchan Kim wrote:
> > +
> > + pr_info("Removed device: %s\n", zram->disk->disk_name);
>
> trivial:
>
> why did you add the info in the middle of logic functions?
> Without special reason, let's add it top of the zram_remove.
>
ok.
-ss
> Acked-by: Minchan Kim
>
On Thu, Apr 16, 2015 at 08:55:53PM +0900, Sergey Senozhatsky wrote:
> With dynamic device creation/removal (which will be introduced later in the
> series) printing num_devices in zram_init() will not make a lot of sense, as
> well as printing the number of destroyed devices in destroy_devices(). P
With dynamic device creation/removal (which will be introduced later in the
series) printing num_devices in zram_init() will not make a lot of sense, as
well as printing the number of destroyed devices in destroy_devices(). Print
per-device action (added/removed) in zram_add() and zram_remove() ins
3 matches
Mail list logo