Re: [PATCHv2 02/14] fork: allow arch-override of VMAP stack alignment

2017-08-15 Thread Catalin Marinas
On Tue, Aug 15, 2017 at 05:39:55PM +0100, Mark Rutland wrote: > On Tue, Aug 15, 2017 at 09:33:18AM -0700, Andy Lutomirski wrote: > > On Tue, Aug 15, 2017 at 9:30 AM, Mark Rutland wrote: > > > On Tue, Aug 15, 2017 at 09:09:36AM -0700, Andy Lutomirski wrote: > > > >> This looks okay, but it might m

Re: [PATCHv2 02/14] fork: allow arch-override of VMAP stack alignment

2017-08-15 Thread Mark Rutland
On Tue, Aug 15, 2017 at 09:33:18AM -0700, Andy Lutomirski wrote: > On Tue, Aug 15, 2017 at 9:30 AM, Mark Rutland wrote: > > On Tue, Aug 15, 2017 at 09:09:36AM -0700, Andy Lutomirski wrote: > >> This looks okay, but it might make sense to move that to a header file > >> so THREAD_ALIGN is always a

Re: [PATCHv2 02/14] fork: allow arch-override of VMAP stack alignment

2017-08-15 Thread Andy Lutomirski
On Tue, Aug 15, 2017 at 9:30 AM, Mark Rutland wrote: > On Tue, Aug 15, 2017 at 09:09:36AM -0700, Andy Lutomirski wrote: >> On Tue, Aug 15, 2017 at 5:50 AM, Mark Rutland wrote: >> > In some cases, an architecture might wish its stacks to be aligned to a >> > boundary larger than THREAD_SIZE. For e

Re: [PATCHv2 02/14] fork: allow arch-override of VMAP stack alignment

2017-08-15 Thread Mark Rutland
On Tue, Aug 15, 2017 at 09:09:36AM -0700, Andy Lutomirski wrote: > On Tue, Aug 15, 2017 at 5:50 AM, Mark Rutland wrote: > > In some cases, an architecture might wish its stacks to be aligned to a > > boundary larger than THREAD_SIZE. For example, using an alignment of > > double THREAD_SIZE can al

Re: [PATCHv2 02/14] fork: allow arch-override of VMAP stack alignment

2017-08-15 Thread Andy Lutomirski
On Tue, Aug 15, 2017 at 5:50 AM, Mark Rutland wrote: > In some cases, an architecture might wish its stacks to be aligned to a > boundary larger than THREAD_SIZE. For example, using an alignment of > double THREAD_SIZE can allow for stack overflows smaller than > THREAD_SIZE to be detected by chec

[PATCHv2 02/14] fork: allow arch-override of VMAP stack alignment

2017-08-15 Thread Mark Rutland
In some cases, an architecture might wish its stacks to be aligned to a boundary larger than THREAD_SIZE. For example, using an alignment of double THREAD_SIZE can allow for stack overflows smaller than THREAD_SIZE to be detected by checking a single bit of the stack pointer. This patch allows arc