Re: [PATCHv2]brd: set max_discard_sectors properly

On Mon, Apr 18, 2016 at 10:34 AM, Jinpu Wang wrote: > On Sat, Apr 16, 2016 at 3:50 AM, Christoph Hellwig wrote: >>> - blk_queue_max_discard_sectors(brd->brd_queue, UINT_MAX); >>> + blk_queue_max_discard_sectors(brd->brd_queue, UINT_MAX >> 9); >> >> Shouldn't we fix the issue by capping to

Re: [PATCHv2]brd: set max_discard_sectors properly

On Sat, Apr 16, 2016 at 3:50 AM, Christoph Hellwig wrote: >> - blk_queue_max_discard_sectors(brd->brd_queue, UINT_MAX); >> + blk_queue_max_discard_sectors(brd->brd_queue, UINT_MAX >> 9); > > Shouldn't we fix the issue by capping to UINT_MAX >> 9 inside > blk_queue_max_discard_sectors? Tha

Re: [PATCHv2]brd: set max_discard_sectors properly

> - blk_queue_max_discard_sectors(brd->brd_queue, UINT_MAX); > + blk_queue_max_discard_sectors(brd->brd_queue, UINT_MAX >> 9); Shouldn't we fix the issue by capping to UINT_MAX >> 9 inside blk_queue_max_discard_sectors? That way we'll prevent against having issues like this in any other d

[PATCHv2]brd: set max_discard_sectors properly

Hi, blkdiscard fails on brd with IO error on 4.4.5, and latest mainline looks the same. nbd and zram has same defect, I can send fix later, if you are Ok with this fix. From a5db7d1acdb54b7f188eb916f711733e34da5b5f Mon Sep 17 00:00:00 2001 From: Jack Wang Date: Fri, 15 Apr 2016 16:05:16 +0200 Sub