Re: [PATCHv11 2/4] zbud: add to mm/

2013-05-23 Thread Mel Gorman
On Thu, May 23, 2013 at 10:00:07AM +0800, Bob Liu wrote: > Hi Mel & Seth, > > On 05/21/2013 04:10 PM, Mel Gorman wrote: > > On Mon, May 20, 2013 at 10:42:25AM -0500, Seth Jennings wrote: > >> On Mon, May 20, 2013 at 02:54:39PM +0100, Mel Gorman wrote: > >>> On Sun, May 19, 2013 at 03:52:19PM -0500

Re: [PATCHv11 2/4] zbud: add to mm/

2013-05-22 Thread Bob Liu
Hi Mel & Seth, On 05/21/2013 04:10 PM, Mel Gorman wrote: > On Mon, May 20, 2013 at 10:42:25AM -0500, Seth Jennings wrote: >> On Mon, May 20, 2013 at 02:54:39PM +0100, Mel Gorman wrote: >>> On Sun, May 19, 2013 at 03:52:19PM -0500, Seth Jennings wrote: My first guess is that the external fragm

Re: [PATCHv11 2/4] zbud: add to mm/

2013-05-21 Thread Mel Gorman
On Mon, May 20, 2013 at 10:42:25AM -0500, Seth Jennings wrote: > On Mon, May 20, 2013 at 02:54:39PM +0100, Mel Gorman wrote: > > On Sun, May 19, 2013 at 03:52:19PM -0500, Seth Jennings wrote: > > > My first guess is that the external fragmentation situation you are > > > referring to > > > is a wo

Re: [PATCHv11 2/4] zbud: add to mm/

2013-05-20 Thread Seth Jennings
On Mon, May 20, 2013 at 02:54:39PM +0100, Mel Gorman wrote: > On Sun, May 19, 2013 at 03:52:19PM -0500, Seth Jennings wrote: > > My first guess is that the external fragmentation situation you are > > referring to > > is a workload in which all pages compress to greater than half a page. If > >

Re: [PATCHv11 2/4] zbud: add to mm/

2013-05-20 Thread Mel Gorman
On Sun, May 19, 2013 at 03:52:19PM -0500, Seth Jennings wrote: > > > > 4 files changed, 597 insertions(+) > > > + * zbud pages are divided into "chunks". The size of the chunks is > > > fixed at > > > + * compile time and determined by NCHUNKS_ORDER below. Dividing zbud > > > pages > > > + *

Re: [PATCHv11 2/4] zbud: add to mm/

2013-05-19 Thread Seth Jennings
On Fri, May 17, 2013 at 04:48:37PM +0100, Mel Gorman wrote: > On Mon, May 13, 2013 at 07:40:01AM -0500, Seth Jennings wrote: > > zbud is an special purpose allocator for storing compressed pages. It is > > designed to store up to two compressed pages per physical page. While this > > design limits

Re: [PATCHv11 2/4] zbud: add to mm/

2013-05-17 Thread Mel Gorman
On Mon, May 13, 2013 at 07:40:01AM -0500, Seth Jennings wrote: > zbud is an special purpose allocator for storing compressed pages. It is > designed to store up to two compressed pages per physical page. While this > design limits storage density, it has simple and deterministic reclaim > properti

Re: [PATCHv11 2/4] zbud: add to mm/

2013-05-16 Thread Rik van Riel
On 05/13/2013 04:59 PM, Seth Jennings wrote: On Mon, May 13, 2013 at 08:43:36AM -0700, Dan Magenheimer wrote: The above appears to be a new addition to my original zbud design. While it may appear to be a good idea for improving LRU-ness, I suspect it may have unexpected side effects in that I

Re: [PATCHv11 2/4] zbud: add to mm/

2013-05-16 Thread Rik van Riel
On 05/13/2013 08:40 AM, Seth Jennings wrote: zbud is an special purpose allocator for storing compressed pages. It is designed to store up to two compressed pages per physical page. While this design limits storage density, it has simple and deterministic reclaim properties that make it preferab

Re: [PATCHv11 2/4] zbud: add to mm/

2013-05-14 Thread Seth Jennings
On Tue, May 14, 2013 at 04:47:24PM +0800, Bob Liu wrote: > Hi Seth, > > On 05/13/2013 08:40 PM, Seth Jennings wrote: > > zbud is an special purpose allocator for storing compressed pages. It is > > designed to store up to two compressed pages per physical page. While this > > design limits storag

Re: [PATCHv11 2/4] zbud: add to mm/

2013-05-14 Thread Bob Liu
Hi Seth, On 05/13/2013 08:40 PM, Seth Jennings wrote: > zbud is an special purpose allocator for storing compressed pages. It is > designed to store up to two compressed pages per physical page. While this > design limits storage density, it has simple and deterministic reclaim > properties that

Re: [PATCHv11 2/4] zbud: add to mm/

2013-05-13 Thread Seth Jennings
On Mon, May 13, 2013 at 08:43:36AM -0700, Dan Magenheimer wrote: > > From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] > > Sent: Monday, May 13, 2013 6:40 AM > > Subject: [PATCHv11 2/4] zbud: add to mm/ > > One comment about a questionable algorithm change (

RE: [PATCHv11 2/4] zbud: add to mm/

2013-05-13 Thread Dan Magenheimer
> From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] > Sent: Monday, May 13, 2013 6:40 AM > Subject: [PATCHv11 2/4] zbud: add to mm/ One comment about a questionable algorithm change (vs my original zbud code) below... I'll leave the detailed code review to others. Dan

[PATCHv11 2/4] zbud: add to mm/

2013-05-13 Thread Seth Jennings
zbud is an special purpose allocator for storing compressed pages. It is designed to store up to two compressed pages per physical page. While this design limits storage density, it has simple and deterministic reclaim properties that make it preferable to a higher density approach when reclaim wi