Re: [PATCHSET v2] sysfs: use seq_file and unify regular and bin file handling

2013-10-14 Thread Tejun Heo
Hello, guys. Sorry about the delay. On Fri, Oct 11, 2013 at 12:11:18PM -0700, Yinghai Lu wrote: > [ 448.189960] [ cut here ] > [ 448.195214] WARNING: CPU: 6 PID: 69219 at fs/sysfs/file.c:79 > sysfs_file_ops+0x59/0x70() So, that's "lockdep_assert_held(sd);" in sysfs_file

Re: [PATCHSET v2] sysfs: use seq_file and unify regular and bin file handling

2013-10-11 Thread Greg KH
On Fri, Oct 11, 2013 at 12:11:18PM -0700, Yinghai Lu wrote: > On Mon, Oct 7, 2013 at 4:11 PM, Greg KH wrote: > > On Mon, Oct 07, 2013 at 01:00:05PM -0400, Tejun Heo wrote: > >> > How are you going to use sysfs from another kernel subsystem? Is this > >> > for another filesystem, or do you want to

Re: [PATCHSET v2] sysfs: use seq_file and unify regular and bin file handling

2013-10-11 Thread Yinghai Lu
On Mon, Oct 7, 2013 at 4:11 PM, Greg KH wrote: > On Mon, Oct 07, 2013 at 01:00:05PM -0400, Tejun Heo wrote: >> > How are you going to use sysfs from another kernel subsystem? Is this >> > for another filesystem, or do you want to use kobjects for some other >> > subsystem that doesn't export them

Re: [PATCHSET v2] sysfs: use seq_file and unify regular and bin file handling

2013-10-07 Thread Greg KH
On Mon, Oct 07, 2013 at 01:00:05PM -0400, Tejun Heo wrote: > > How are you going to use sysfs from another kernel subsystem? Is this > > for another filesystem, or do you want to use kobjects for some other > > subsystem that doesn't export them using sysfs? > > I was at first trying to convert s

Re: [PATCHSET v2] sysfs: use seq_file and unify regular and bin file handling

2013-10-07 Thread Tejun Heo
Hello, On Sat, Oct 05, 2013 at 05:40:32PM -0700, Greg KH wrote: > > * 0001-0008 are the same as before. > > Nice, I've applied all of these now. Great! > How are you going to use sysfs from another kernel subsystem? Is this > for another filesystem, or do you want to use kobjects for some othe

Re: [PATCHSET v2] sysfs: use seq_file and unify regular and bin file handling

2013-10-05 Thread Greg KH
On Tue, Oct 01, 2013 at 05:41:54PM -0400, Tejun Heo wrote: > Hello, > > Changes from the last take[L] are, > > * bin file reads no longer go through seq_file. It goes through a > separate read path implemented in sysfs_bin_read(). bin files > shouldn't see any behavior difference now. > >

[PATCHSET v2] sysfs: use seq_file and unify regular and bin file handling

2013-10-01 Thread Tejun Heo
Hello, Changes from the last take[L] are, * bin file reads no longer go through seq_file. It goes through a separate read path implemented in sysfs_bin_read(). bin files shouldn't see any behavior difference now. * bin files now use a separate file_operations struct - sysfs_bin_operation