Re: [PATCH x86/mm 05/11] x86 ptrace getreg/putreg merge

2007-11-30 Thread Ingo Molnar
* Roland McGrath <[EMAIL PROTECTED]> wrote: > > This didn't need to be implemented as a macro hence it shouldn't have been. > > Ok. > > > diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c > index b3433e1..000 100644 > --- a/arch/x86/kernel/ptrace.c > +++ b/arch/x86/kernel/

Re: [PATCH x86/mm 05/11] x86 ptrace getreg/putreg merge

2007-11-29 Thread Roland McGrath
> This didn't need to be implemented as a macro hence it shouldn't have been. Ok. diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c index b3433e1..000 100644 --- a/arch/x86/kernel/ptrace.c +++ b/arch/x86/kernel/ptrace.c @@ -45,8 +45,10 @@ /* * Determines whether a value m

Re: [PATCH x86/mm 05/11] x86 ptrace getreg/putreg merge

2007-11-29 Thread Andrew Morton
On Thu, 29 Nov 2007 03:59:54 -0800 (PST) Roland McGrath <[EMAIL PROTECTED]> wrote: > +/* > + * Determines whether a value may be installed in a segment register. > + */ > +#define invalid_selector(value) \ > + ((value) != 0 && ((value) & SEGMENT_RPL_MASK) != USER_RPL) This didn't need to be

[PATCH x86/mm 05/11] x86 ptrace getreg/putreg merge

2007-11-29 Thread Roland McGrath
This merges 64-bit support into the low-level register access functions in arch/x86/kernel/ptrace.c, paving the way to share this file between 32-bit and 64-bit builds. Signed-off-by: Roland McGrath <[EMAIL PROTECTED]> --- arch/x86/kernel/ptrace.c | 215 +