Re: [PATCH vfs/for-next 00/18] fs_context fixes

2018-07-09 Thread David Howells
Okay, how about the attached? David --- commit 0f067bdbfeca03264a50461db21339dbcd97e8f3 Author: David Howells Date: Mon Jul 9 16:24:27 2018 +0100 vfs: Separate changing mount flags full remount Separate just the changing of mount flags (MS_REMOUNT|MS_BIND) from full remount be

Re: [PATCH vfs/for-next 00/18] fs_context fixes

2018-07-09 Thread David Howells
Al Viro wrote: > Egads... *If* you go for bool here, why not > return (mnt->mnt_flags & MNT_READONLY) || sb_rdonly(mnt->mnt_sb); > and be done with that? Fair point; I'll do that when I get back later. David

Re: [PATCH vfs/for-next 00/18] fs_context fixes

2018-07-09 Thread Al Viro
On Mon, Jul 09, 2018 at 04:31:59PM +0100, David Howells wrote: > -int __mnt_is_readonly(struct vfsmount *mnt) > +bool __mnt_is_readonly(struct vfsmount *mnt) > { > if (mnt->mnt_flags & MNT_READONLY) > - return 1; > + return true; > if (sb_rdonly(mnt->mnt_sb)) >

Re: [PATCH vfs/for-next 00/18] fs_context fixes

2018-07-09 Thread David Howells
Eric Biggers wrote: Okay, I've folded in all your changes to my mount-context branch, apart from patch 07 (the legacy wrapper double free fix) which I think needed doing differently. > Also, mount(..., MS_REMOUNT|MS_BIND, ...) now validates the mount options > string, which breaks systemd unit f

Re: [PATCH vfs/for-next 00/18] fs_context fixes

2018-07-08 Thread Eric Biggers
On Sun, Jul 08, 2018 at 02:01:36PM -0700, Eric Biggers wrote: > Hi David and Al, here are some fixes for the fs_context patches. > > Feel free to fold these into the original patches if you want. > > Patches 13-18 are cleanups only. > Also, mount(..., MS_REMOUNT|MS_BIND, ...) now validates the

[PATCH vfs/for-next 00/18] fs_context fixes

2018-07-08 Thread Eric Biggers
Hi David and Al, here are some fixes for the fs_context patches. Feel free to fold these into the original patches if you want. Patches 13-18 are cleanups only. Eric Biggers (18): sysfs: check return value of kernfs_get_tree() fs_context: fix shrinker leak in sget_fc() fs_context: fix dete