Re: [PATCH v9 net-next 2/7] net: add low latency socket poll

2013-06-06 Thread Eliezer Tamir
On 05/06/2013 18:59, Eric Dumazet wrote: On Wed, 2013-06-05 at 18:46 +0300, Eliezer Tamir wrote: On 05/06/2013 18:39, Eric Dumazet wrote: On Wed, 2013-06-05 at 18:30 +0300, Eliezer Tamir wrote: On 05/06/2013 18:21, Eric Dumazet wrote: It would also make sense to give end_time as a parameter

Re: [PATCH v9 net-next 2/7] net: add low latency socket poll

2013-06-05 Thread Eric Dumazet
On Wed, 2013-06-05 at 18:46 +0300, Eliezer Tamir wrote: > On 05/06/2013 18:39, Eric Dumazet wrote: > > On Wed, 2013-06-05 at 18:30 +0300, Eliezer Tamir wrote: > >> On 05/06/2013 18:21, Eric Dumazet wrote: > > >>> It would also make sense to give end_time as a parameter, so that the > >>> polling()

Re: [PATCH v9 net-next 2/7] net: add low latency socket poll

2013-06-05 Thread Eliezer Tamir
On 05/06/2013 18:39, Eric Dumazet wrote: On Wed, 2013-06-05 at 18:30 +0300, Eliezer Tamir wrote: On 05/06/2013 18:21, Eric Dumazet wrote: It would also make sense to give end_time as a parameter, so that the polling() code could really give a end_time for the whole duration of poll(). (You

Re: [PATCH v9 net-next 2/7] net: add low latency socket poll

2013-06-05 Thread Eric Dumazet
On Wed, 2013-06-05 at 18:30 +0300, Eliezer Tamir wrote: > On 05/06/2013 18:21, Eric Dumazet wrote: > > On Wed, 2013-06-05 at 13:34 +0300, Eliezer Tamir wrote: > > > > > > This is probably too big to be inlined, and nonblock should be a bool > > > > It would also make sense to give end_time as a p

Re: [PATCH v9 net-next 2/7] net: add low latency socket poll

2013-06-05 Thread Willem de Bruijn
On Wed, Jun 5, 2013 at 9:23 AM, Eric Dumazet wrote: > On Wed, 2013-06-05 at 13:34 +0300, Eliezer Tamir wrote: >> Adds an ndo_ll_poll method and the code that supports it. >> This method can be used by low latency applications to busy-poll >> Ethernet device queues directly from the socket code. >>

Re: [PATCH v9 net-next 2/7] net: add low latency socket poll

2013-06-05 Thread Eliezer Tamir
On 05/06/2013 18:28, Willem de Bruijn wrote: On Wed, Jun 5, 2013 at 9:23 AM, Eric Dumazet wrote: On Wed, 2013-06-05 at 13:34 +0300, Eliezer Tamir wrote: Adds an ndo_ll_poll method and the code that supports it. This method can be used by low latency applications to busy-poll Ethernet device qu

Re: [PATCH v9 net-next 2/7] net: add low latency socket poll

2013-06-05 Thread Eliezer Tamir
On 05/06/2013 18:21, Eric Dumazet wrote: On Wed, 2013-06-05 at 13:34 +0300, Eliezer Tamir wrote: This is probably too big to be inlined, and nonblock should be a bool It would also make sense to give end_time as a parameter, so that the polling() code could really give a end_time for the

Re: [PATCH v9 net-next 2/7] net: add low latency socket poll

2013-06-05 Thread Eric Dumazet
On Wed, 2013-06-05 at 13:34 +0300, Eliezer Tamir wrote: This is probably too big to be inlined, and nonblock should be a bool It would also make sense to give end_time as a parameter, so that the polling() code could really give a end_time for the whole duration of poll(). (You then should te

Re: [PATCH v9 net-next 2/7] net: add low latency socket poll

2013-06-05 Thread Eric Dumazet
On Wed, 2013-06-05 at 13:34 +0300, Eliezer Tamir wrote: > Adds an ndo_ll_poll method and the code that supports it. > This method can be used by low latency applications to busy-poll > Ethernet device queues directly from the socket code. > sysctl_net_ll_poll controls how many microseconds to poll.

[PATCH v9 net-next 2/7] net: add low latency socket poll

2013-06-05 Thread Eliezer Tamir
Adds an ndo_ll_poll method and the code that supports it. This method can be used by low latency applications to busy-poll Ethernet device queues directly from the socket code. sysctl_net_ll_poll controls how many microseconds to poll. Default is zero (disabled). Individual protocol support will be