Re: [PATCH v9 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-10-16 Thread Viktor Rosendahl (BMW)
> Something bothers me. If you dropped support for HWLAT_TRACER as you > mentioned in the cover letter, then why does this #if look for the CONFIG > option? You are right. I forgot to change those #if statements; I also overlooked to give the -i option to grep when I searched for remaining referen

Re: [PATCH v9 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-10-15 Thread Steven Rostedt
On Tue, 15 Oct 2019 20:41:20 -0400 Joel Fernandes wrote: > > +static const struct file_operations tracing_max_lat_fops; > > + > > +#if (defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER)) && \ > > + defined(CONFIG_FSNOTIFY) > > Something bothers me. If you dropped support for H

Re: [PATCH v9 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-10-15 Thread Joel Fernandes
On Tue, Oct 15, 2019 at 01:19:07PM +0200, Viktor Rosendahl (BMW) wrote: > This patch implements the feature that the tracing_max_latency file, > e.g. /sys/kernel/debug/tracing/tracing_max_latency will receive > notifications through the fsnotify framework when a new latency is > available. > > One

[PATCH v9 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-10-15 Thread Viktor Rosendahl (BMW)
This patch implements the feature that the tracing_max_latency file, e.g. /sys/kernel/debug/tracing/tracing_max_latency will receive notifications through the fsnotify framework when a new latency is available. One particularly interesting use of this facility is when enabling threshold tracing, t