Re: [PATCH v9 1/2] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

2018-07-05 Thread Lee Jones
> > > > > +++ b/include/linux/mfd/bd71837.h > > > > > @@ -0,0 +1,391 @@ > > > > > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > > > > > > > > I thought these were meant to use C++ (//) comments? > > > > > > The checkpatch.pl did complain if I used // comment on SPDX line for > > > header fil

Re: [PATCH v9 1/2] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

2018-07-05 Thread Matti Vaittinen
On Thu, Jul 05, 2018 at 12:17:05PM +0100, Lee Jones wrote: > On Thu, 05 Jul 2018, Matti Vaittinen wrote: > > > Thanks for taking the time to check this =) > > > > On Thu, Jul 05, 2018 at 10:18:13AM +0100, Lee Jones wrote: > > > On Thu, 05 Jul 2018, Matti Vaittinen wrote: > > > > > > > --- a/driv

Re: [PATCH v9 1/2] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

2018-07-05 Thread Lee Jones
On Thu, 05 Jul 2018, Matti Vaittinen wrote: > Thanks for taking the time to check this =) > > On Thu, Jul 05, 2018 at 10:18:13AM +0100, Lee Jones wrote: > > On Thu, 05 Jul 2018, Matti Vaittinen wrote: > > > > > --- a/drivers/mfd/Kconfig > > > +++ b/drivers/mfd/Kconfig > > > @@ -1787,6 +1787,19 @

Re: [PATCH v9 1/2] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

2018-07-05 Thread Matti Vaittinen
Thanks for taking the time to check this =) On Thu, Jul 05, 2018 at 10:18:13AM +0100, Lee Jones wrote: > On Thu, 05 Jul 2018, Matti Vaittinen wrote: > > > --- a/drivers/mfd/Kconfig > > +++ b/drivers/mfd/Kconfig > > @@ -1787,6 +1787,19 @@ config MFD_STW481X > > in various ST Microelectronics

Re: [PATCH v9 1/2] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

2018-07-05 Thread Lee Jones
On Thu, 05 Jul 2018, Matti Vaittinen wrote: > ROHM BD71837 PMIC MFD driver providing interrupts and support > for three subsystems: > - clk > - Regulators > - input/power-key > > Signed-off-by: Matti Vaittinen > --- > drivers/mfd/Kconfig | 13 ++ > drivers/mfd/Makefile| 1 + >

Re: [PATCH v9 1/2] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

2018-07-05 Thread Enric Balletbo Serra
Hi Matti, Missatge de Matti Vaittinen del dia dj., 5 de jul. 2018 a les 9:46: > > ROHM BD71837 PMIC MFD driver providing interrupts and support > for three subsystems: > - clk > - Regulators > - input/power-key > > Signed-off-by: Matti Vaittinen > --- > drivers/mfd/Kconfig | 13 ++ > dr

[PATCH v9 1/2] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

2018-07-05 Thread Matti Vaittinen
ROHM BD71837 PMIC MFD driver providing interrupts and support for three subsystems: - clk - Regulators - input/power-key Signed-off-by: Matti Vaittinen --- drivers/mfd/Kconfig | 13 ++ drivers/mfd/Makefile| 1 + drivers/mfd/bd71837.c | 215 inclu