Re: [PATCH v8 3/3] aerdrv: Cleanup log output for AER

2013-01-03 Thread Borislav Petkov
On Wed, Jan 02, 2013 at 03:41:19PM -0800, Tony Luck wrote: > On Wed, Jan 2, 2013 at 3:27 PM, Joe Perches wrote: > > Just use dev_err( instead of dev_printk(KERN_ERR, > > It's a function and it makes the object code smaller. > > Looks like we are almost converged on a solution (Lance: thanks for >

Re: [PATCH v8 3/3] aerdrv: Cleanup log output for AER

2013-01-02 Thread Tony Luck
On Wed, Jan 2, 2013 at 3:27 PM, Joe Perches wrote: > Just use dev_err( instead of dev_printk(KERN_ERR, > It's a function and it makes the object code smaller. Looks like we are almost converged on a solution (Lance: thanks for your patience and diligence in making changes). Anyone on the "To:" l

Re: [PATCH v8 3/3] aerdrv: Cleanup log output for AER

2013-01-02 Thread Joe Perches
On Wed, 2013-01-02 at 16:27 -0700, Lance Ortiz wrote: > These changes make cper_print_aer more consistent with aer_print_error > and clean things up by elimiating the use of the prefix variable and > replacing it with dev_printk. [] > v7-v8 Updated to use dev_printk instated of prefix. Changed > lo

[PATCH v8 3/3] aerdrv: Cleanup log output for AER

2013-01-02 Thread Lance Ortiz
These changes make cper_print_aer more consistent with aer_print_error and clean things up by elimiating the use of the prefix variable and replacing it with dev_printk. v1-v2 fix some compile errors withinn the #ifdef v3-v4 remove agent id stuff and kept print the same to avoid compatibility issu