Re: [PATCH v8 2/6] time: sync read_boot_clock64() with persistent clock

2017-11-14 Thread Pavel Tatashin
> IMO, using the extern keyword on function prototypes in *.h files > is superfluous, but, It doesn't matter for functionality. *extern* > is default keywords. > > AFAIK, it's a code style problem. In x86 arch, we prefer to > keep *extern* explicitly, so, let's keep it like before for > code consis

Re: [PATCH v8 2/6] time: sync read_boot_clock64() with persistent clock

2017-11-14 Thread Dou Liyang
Hi Pavel, At 11/15/2017 03:57 AM, Pavel Tatashin wrote: why we should remove the *extern* keyword? Hi Dou, While, I am not sure why it was decided to stop using externs in headers, this is a warning printed by scripts/checkpatch.pl: CHECK: extern prototypes should be avoided in .h files To

Re: [PATCH v8 2/6] time: sync read_boot_clock64() with persistent clock

2017-11-14 Thread Pavel Tatashin
> why we should remove the *extern* keyword? Hi Dou, While, I am not sure why it was decided to stop using externs in headers, this is a warning printed by scripts/checkpatch.pl: CHECK: extern prototypes should be avoided in .h files To have a clean checkpatch output I removed externs. Pavel

Re: [PATCH v8 2/6] time: sync read_boot_clock64() with persistent clock

2017-11-12 Thread Dou Liyang
Hi Pavel, At 11/09/2017 11:01 AM, Pavel Tatashin wrote: read_boot_clock64() returns a boot start timestamp from epoch. Some arches may need to access the persistent clock interface in order to calculate the epoch offset. The resolution of the persistent clock, however, might be low. Therefore,

[PATCH v8 2/6] time: sync read_boot_clock64() with persistent clock

2017-11-08 Thread Pavel Tatashin
read_boot_clock64() returns a boot start timestamp from epoch. Some arches may need to access the persistent clock interface in order to calculate the epoch offset. The resolution of the persistent clock, however, might be low. Therefore, in order to avoid time discrepancies a new argument 'now' i