Re: [PATCH v8 2/5] tpm: Add optional logging of TPM command durations

2016-06-24 Thread Jarkko Sakkinen
On Fri, Jun 24, 2016 at 12:27:27PM -0600, Jason Gunthorpe wrote: > On Tue, Jun 21, 2016 at 06:10:28PM -0700, Ed Swierk wrote: > > > if (chip->ops->req_canceled(chip, status)) { > > dev_err(chip->pdev, "Operation Canceled\n"); > > + dev_dbg(chip->pd

Re: [PATCH v8 2/5] tpm: Add optional logging of TPM command durations

2016-06-24 Thread Jason Gunthorpe
On Tue, Jun 21, 2016 at 06:10:28PM -0700, Ed Swierk wrote: > if (chip->ops->req_canceled(chip, status)) { > dev_err(chip->pdev, "Operation Canceled\n"); > + dev_dbg(chip->pdev, "canceled command %d after %d ms\n", > +

[PATCH v8 2/5] tpm: Add optional logging of TPM command durations

2016-06-21 Thread Ed Swierk
Some TPMs violate their own advertised command durations. This is much easier to debug with data about how long each command actually takes to complete. Add debug messages that can be enabled by running echo -n 'module tpm +p' >/sys/kernel/debug/dynamic_debug/control on a kernel configured with