Re: [PATCH v8 2/3] modpost: Produce extended MODVERSIONS information

2024-11-21 Thread Matthew Maurer
On Thu, Nov 7, 2024 at 2:38 PM Luis Chamberlain wrote: > > On Wed, Nov 06, 2024 at 02:19:38PM -0800, Matthew Maurer wrote: > > > > > > > If booted against an old kernel, it will > > > > behave as though there is no modversions information. > > > > > > Huh? This I don't get. If you have the new lib

Re: [PATCH v8 2/3] modpost: Produce extended MODVERSIONS information

2024-11-18 Thread Luis Chamberlain
On Mon, Nov 18, 2024 at 04:09:34PM -0800, Matthew Maurer wrote: > > Thinking about this some more, if we're going down enabling a new > > option, it seems to beg the question if the old *two* ksymtab sections > > could just be folded into the a new one where the "gpl only" thing > > becomes just on

Re: [PATCH v8 2/3] modpost: Produce extended MODVERSIONS information

2024-11-18 Thread Luis Chamberlain
On Thu, Nov 07, 2024 at 02:38:13PM -0800, Luis Chamberlain wrote: > The only thing left I think to test is the impact at runtime, and the > only thing I can think of is first we use find_symbol() on resolve_symbol() > which it took me a while to review and realize that this just uses a > completel

Re: [PATCH v8 2/3] modpost: Produce extended MODVERSIONS information

2024-11-18 Thread Matthew Maurer
> Thinking about this some more, if we're going down enabling a new > option, it seems to beg the question if the old *two* ksymtab sections > could just be folded into the a new one where the "gpl only" thing > becomes just one "column" as you call it. Reasons I ask, it seems like > we're duplicat

Re: [PATCH v8 2/3] modpost: Produce extended MODVERSIONS information

2024-11-07 Thread Luis Chamberlain
On Wed, Nov 06, 2024 at 02:19:38PM -0800, Matthew Maurer wrote: > > > > > If booted against an old kernel, it will > > > behave as though there is no modversions information. > > > > Huh? This I don't get. If you have the new libkmod and boot > > an old kernel, that should just not break becauase w

Re: [PATCH v8 2/3] modpost: Produce extended MODVERSIONS information

2024-11-07 Thread Matthew Maurer
On Wed, Nov 6, 2024 at 10:27 PM Lucas De Marchi wrote: > > On Wed, Nov 06, 2024 at 02:19:38PM -0800, Matthew Maurer wrote: > >> > >> > If booted against an old kernel, it will > >> > behave as though there is no modversions information. > >> > >> Huh? This I don't get. If you have the new libkmod

Re: [PATCH v8 2/3] modpost: Produce extended MODVERSIONS information

2024-11-06 Thread Lucas De Marchi
On Wed, Nov 06, 2024 at 02:19:38PM -0800, Matthew Maurer wrote: > If booted against an old kernel, it will > behave as though there is no modversions information. Huh? This I don't get. If you have the new libkmod and boot an old kernel, that should just not break becauase well, long symbols we

Re: [PATCH v8 2/3] modpost: Produce extended MODVERSIONS information

2024-11-06 Thread Matthew Maurer
> > > If booted against an old kernel, it will > > behave as though there is no modversions information. > > Huh? This I don't get. If you have the new libkmod and boot > an old kernel, that should just not break becauase well, long > symbols were not ever supported properly anyway, so no regressio

Re: [PATCH v8 2/3] modpost: Produce extended MODVERSIONS information

2024-11-05 Thread Luis Chamberlain
On Tue, Nov 05, 2024 at 04:26:51PM -0800, Matthew Maurer wrote: > On Fri, Nov 1, 2024 at 2:10 PM Luis Chamberlain wrote: > > > > On Thu, Oct 31, 2024 at 01:00:28PM -0700, Matthew Maurer wrote: > > > > The question is, if only extended moversions are used, what new tooling > > > > requirements are

Re: [PATCH v8 2/3] modpost: Produce extended MODVERSIONS information

2024-11-05 Thread Matthew Maurer
On Fri, Nov 1, 2024 at 2:10 PM Luis Chamberlain wrote: > > On Thu, Oct 31, 2024 at 01:00:28PM -0700, Matthew Maurer wrote: > > > The question is, if only extended moversions are used, what new tooling > > > requirements are there? Can you test using only extended modversions? > > > > > > Luis >

Re: [PATCH v8 2/3] modpost: Produce extended MODVERSIONS information

2024-11-01 Thread Luis Chamberlain
On Thu, Oct 31, 2024 at 01:00:28PM -0700, Matthew Maurer wrote: > > The question is, if only extended moversions are used, what new tooling > > requirements are there? Can you test using only extended modversions? > > > > Luis > > I'm not sure precisely what you're asking for. Do you want: > 1.

Re: [PATCH v8 2/3] modpost: Produce extended MODVERSIONS information

2024-10-31 Thread Matthew Maurer
> The question is, if only extended moversions are used, what new tooling > requirements are there? Can you test using only extended modversions? > > Luis I'm not sure precisely what you're asking for. Do you want: 1. A kconfig that suppresses the emission of today's MODVERSIONS format? This wou

Re: [PATCH v8 2/3] modpost: Produce extended MODVERSIONS information

2024-10-31 Thread Luis Chamberlain
On Wed, Oct 30, 2024 at 11:05:03PM +, Matthew Maurer wrote: > diff --git a/kernel/module/Kconfig b/kernel/module/Kconfig > index > e6b2427e5c190aacf7b9c5c1bb57fca39d311564..a31c617cd67d3d66b24d2fba34cbd5cc9c53ab78 > 100644 > --- a/kernel/module/Kconfig > +++ b/kernel/module/Kconfig > @@ -208,

[PATCH v8 2/3] modpost: Produce extended MODVERSIONS information

2024-10-30 Thread Matthew Maurer
Generate both the existing modversions format and the new extended one when running modpost. Presence of this metadata in the final .ko is guarded by CONFIG_EXTENDED_MODVERSIONS. We no longer generate an error on long symbols in modpost if CONFIG_EXTENDED_MODVERSIONS is set, as they can now be app