Re: [PATCH v8 10/10] MCS Lock: Make mcs_spinlock.h includable in other files

2013-10-24 Thread Waiman Long
On 10/24/2013 04:58 PM, Tim Chen wrote: Do we want to inline the unlock? Will that prevent proper profile accounting of unlock overhead? Can we keep the mcs_spin_unlock and mcs_spin_lock in the same kernel/mcs_spinlock.c file? That makes it easier to read and maintain the code. The unlock co

Re: [PATCH v8 10/10] MCS Lock: Make mcs_spinlock.h includable in other files

2013-10-24 Thread Tim Chen
On Thu, 2013-10-24 at 16:01 -0400, Waiman Long wrote: > The following changes are made to enable mcs_spinlock.h file to be > widely included in other files without causing problem: > > 1) Include a number of prerequisite header files and define >arch_mutex_cpu_relax(), if not previously define

[PATCH v8 10/10] MCS Lock: Make mcs_spinlock.h includable in other files

2013-10-24 Thread Waiman Long
The following changes are made to enable mcs_spinlock.h file to be widely included in other files without causing problem: 1) Include a number of prerequisite header files and define arch_mutex_cpu_relax(), if not previously defined. 2) Separate out mcs_spin_lock() into a mcs_spinlock.c file. 3