Re: [Linaro-acpi] [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-06 Thread Ard Biesheuvel
On 6 February 2015 at 14:16, Catalin Marinas wrote: > On Fri, Feb 06, 2015 at 11:08:51AM +, Ard Biesheuvel wrote: >> On 6 February 2015 at 10:36, Catalin Marinas wrote: >> > On Thu, Feb 05, 2015 at 10:16:03PM +, Ard Biesheuvel wrote: >> >> On 5 February 2015 at 17:48, Catalin Marinas >>

Re: [Linaro-acpi] [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-06 Thread Catalin Marinas
On Fri, Feb 06, 2015 at 11:08:51AM +, Ard Biesheuvel wrote: > On 6 February 2015 at 10:36, Catalin Marinas wrote: > > On Thu, Feb 05, 2015 at 10:16:03PM +, Ard Biesheuvel wrote: > >> On 5 February 2015 at 17:48, Catalin Marinas > >> wrote: > >> > On Thu, Feb 05, 2015 at 04:42:19PM +,

Re: [Linaro-acpi] [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-06 Thread Ard Biesheuvel
On 6 February 2015 at 10:36, Catalin Marinas wrote: > On Thu, Feb 05, 2015 at 10:16:03PM +, Ard Biesheuvel wrote: >> On 5 February 2015 at 17:48, Catalin Marinas wrote: >> > On Thu, Feb 05, 2015 at 04:42:19PM +, Al Stone wrote: >> >> On 02/05/2015 06:54 AM, Mark Salter wrote: >> >> > On T

Re: [Linaro-acpi] [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-06 Thread Catalin Marinas
On Thu, Feb 05, 2015 at 10:16:03PM +, Ard Biesheuvel wrote: > On 5 February 2015 at 17:48, Catalin Marinas wrote: > > On Thu, Feb 05, 2015 at 04:42:19PM +, Al Stone wrote: > >> On 02/05/2015 06:54 AM, Mark Salter wrote: > >> > On Thu, 2015-02-05 at 10:41 +, Catalin Marinas wrote: > >>

Re: [Linaro-acpi] [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-05 Thread Ard Biesheuvel
On 5 February 2015 at 17:48, Catalin Marinas wrote: > On Thu, Feb 05, 2015 at 04:42:19PM +, Al Stone wrote: >> On 02/05/2015 06:54 AM, Mark Salter wrote: >> > On Thu, 2015-02-05 at 10:41 +, Catalin Marinas wrote: >> >> On Wed, Feb 04, 2015 at 06:58:14PM +, Mark Salter wrote: >> >>> On

Re: [Linaro-acpi] [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-05 Thread Catalin Marinas
On Thu, Feb 05, 2015 at 04:42:19PM +, Al Stone wrote: > On 02/05/2015 06:54 AM, Mark Salter wrote: > > On Thu, 2015-02-05 at 10:41 +, Catalin Marinas wrote: > >> On Wed, Feb 04, 2015 at 06:58:14PM +, Mark Salter wrote: > >>> On Wed, 2015-02-04 at 17:57 +, Catalin Marinas wrote: > >>

Re: [Linaro-acpi] [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-05 Thread Al Stone
On 02/05/2015 06:54 AM, Mark Salter wrote: > On Thu, 2015-02-05 at 10:41 +, Catalin Marinas wrote: >> On Wed, Feb 04, 2015 at 06:58:14PM +, Mark Salter wrote: >>> On Wed, 2015-02-04 at 17:57 +, Catalin Marinas wrote: On Wed, Feb 04, 2015 at 04:08:27PM +, Mark Salter wrote:

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-05 Thread Catalin Marinas
On Thu, Feb 05, 2015 at 12:52:08PM +, Graeme Gregory wrote: > On Thu, Feb 05, 2015 at 12:07:20PM +, Catalin Marinas wrote: > > On Thu, Feb 05, 2015 at 11:14:43AM +, Graeme Gregory wrote: > > > On Thu, Feb 05, 2015 at 10:59:45AM +, Catalin Marinas wrote: > > > > On Thu, Feb 05, 2015

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-05 Thread Mark Salter
On Thu, 2015-02-05 at 10:41 +, Catalin Marinas wrote: > On Wed, Feb 04, 2015 at 06:58:14PM +, Mark Salter wrote: > > On Wed, 2015-02-04 at 17:57 +, Catalin Marinas wrote: > > > On Wed, Feb 04, 2015 at 04:08:27PM +, Mark Salter wrote: > > > > acpi_os_remap() is used to map ACPI table

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-05 Thread Ard Biesheuvel
On 5 February 2015 at 12:07, Catalin Marinas wrote: > On Thu, Feb 05, 2015 at 11:14:43AM +, Graeme Gregory wrote: >> On Thu, Feb 05, 2015 at 10:59:45AM +, Catalin Marinas wrote: >> > On Thu, Feb 05, 2015 at 10:47:23AM +, Ard Biesheuvel wrote: >> > > On 5 February 2015 at 10:41, Catalin

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-05 Thread Graeme Gregory
On Thu, Feb 05, 2015 at 12:07:20PM +, Catalin Marinas wrote: > On Thu, Feb 05, 2015 at 11:14:43AM +, Graeme Gregory wrote: > > On Thu, Feb 05, 2015 at 10:59:45AM +, Catalin Marinas wrote: > > > On Thu, Feb 05, 2015 at 10:47:23AM +, Ard Biesheuvel wrote: > > > > On 5 February 2015 at

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-05 Thread Catalin Marinas
On Thu, Feb 05, 2015 at 11:14:43AM +, Graeme Gregory wrote: > On Thu, Feb 05, 2015 at 10:59:45AM +, Catalin Marinas wrote: > > On Thu, Feb 05, 2015 at 10:47:23AM +, Ard Biesheuvel wrote: > > > On 5 February 2015 at 10:41, Catalin Marinas > > > wrote: > > > > On Wed, Feb 04, 2015 at 06

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-05 Thread Graeme Gregory
On Thu, Feb 05, 2015 at 10:59:45AM +, Catalin Marinas wrote: > On Thu, Feb 05, 2015 at 10:47:23AM +, Ard Biesheuvel wrote: > > On 5 February 2015 at 10:41, Catalin Marinas > > wrote: > > > On Wed, Feb 04, 2015 at 06:58:14PM +, Mark Salter wrote: > > >> On Wed, 2015-02-04 at 17:57 +000

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-05 Thread Catalin Marinas
On Thu, Feb 05, 2015 at 10:47:23AM +, Ard Biesheuvel wrote: > On 5 February 2015 at 10:41, Catalin Marinas wrote: > > On Wed, Feb 04, 2015 at 06:58:14PM +, Mark Salter wrote: > >> On Wed, 2015-02-04 at 17:57 +, Catalin Marinas wrote: > >> > On Wed, Feb 04, 2015 at 04:08:27PM +, Mar

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-05 Thread Ard Biesheuvel
On 5 February 2015 at 10:41, Catalin Marinas wrote: > On Wed, Feb 04, 2015 at 06:58:14PM +, Mark Salter wrote: >> On Wed, 2015-02-04 at 17:57 +, Catalin Marinas wrote: >> > On Wed, Feb 04, 2015 at 04:08:27PM +, Mark Salter wrote: >> > > acpi_os_remap() is used to map ACPI tables. These

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-05 Thread Catalin Marinas
On Wed, Feb 04, 2015 at 06:58:14PM +, Mark Salter wrote: > On Wed, 2015-02-04 at 17:57 +, Catalin Marinas wrote: > > On Wed, Feb 04, 2015 at 04:08:27PM +, Mark Salter wrote: > > > acpi_os_remap() is used to map ACPI tables. These tables may be in ram > > > which are already included in

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-04 Thread Rafael J. Wysocki
On Tuesday, February 03, 2015 12:29:36 PM Mark Salter wrote: > On Mon, 2015-02-02 at 23:14 +0100, Rafael J. Wysocki wrote: > > On Monday, February 02, 2015 08:45:30 PM Hanjun Guo wrote: > > > From: Mark Salter > > > > > > The acpi_os_ioremap() function may be used to map normal RAM or IO > > > re

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-04 Thread Mark Salter
On Wed, 2015-02-04 at 17:57 +, Catalin Marinas wrote: > On Wed, Feb 04, 2015 at 04:08:27PM +, Mark Salter wrote: > > On Wed, 2015-02-04 at 11:25 +, Catalin Marinas wrote: > > > On Tue, Feb 03, 2015 at 05:29:36PM +, Mark Salter wrote: > > > > On Mon, 2015-02-02 at 23:14 +0100, Rafael

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-04 Thread Catalin Marinas
On Wed, Feb 04, 2015 at 04:08:27PM +, Mark Salter wrote: > On Wed, 2015-02-04 at 11:25 +, Catalin Marinas wrote: > > On Tue, Feb 03, 2015 at 05:29:36PM +, Mark Salter wrote: > > > On Mon, 2015-02-02 at 23:14 +0100, Rafael J. Wysocki wrote: > > > > On Monday, February 02, 2015 08:45:30 P

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-04 Thread Catalin Marinas
On Wed, Feb 04, 2015 at 04:16:34PM +, Timur Tabi wrote: > On 02/04/2015 10:08 AM, Mark Salter wrote: > > acpi_os_remap() is used to map ACPI tables. These tables may be in ram > > which are already included in the kernel's linear RAM mapping. So we > > need ioremap_cache to avoid two mappings t

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-04 Thread Bjorn Helgaas
On Wed, Feb 4, 2015 at 10:25 AM, Russell King - ARM Linux wrote: > On Wed, Feb 04, 2015 at 09:53:28AM -0600, Bjorn Helgaas wrote: >> On Wed, Feb 4, 2015 at 4:48 AM, Russell King - ARM Linux >> wrote: >> > Moreover, __weak is positively harmful when you consider it adds bloat >> > and dead code -

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-04 Thread David Woodhouse
On Wed, 2015-02-04 at 16:25 +, Russell King - ARM Linux wrote: > I haven't experimented with it myself, but I think David Woodhouse > has some experience in this area. In many kernel configurations there are actually quite a lot of functions that are never called, and I was quite surprised the

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-04 Thread Russell King - ARM Linux
On Wed, Feb 04, 2015 at 09:53:28AM -0600, Bjorn Helgaas wrote: > On Wed, Feb 4, 2015 at 4:48 AM, Russell King - ARM Linux > wrote: > > Moreover, __weak is positively harmful when you consider it adds bloat > > and dead code - the overriden __weak function is left behind in the > > resulting final

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-04 Thread Timur Tabi
On 02/04/2015 10:08 AM, Mark Salter wrote: acpi_os_remap() is used to map ACPI tables. These tables may be in ram which are already included in the kernel's linear RAM mapping. So we need ioremap_cache to avoid two mappings to the same physical page having different caching attributes. Would it

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-04 Thread Mark Salter
On Wed, 2015-02-04 at 11:25 +, Catalin Marinas wrote: > On Tue, Feb 03, 2015 at 05:29:36PM +, Mark Salter wrote: > > On Mon, 2015-02-02 at 23:14 +0100, Rafael J. Wysocki wrote: > > > On Monday, February 02, 2015 08:45:30 PM Hanjun Guo wrote: > > > > From: Mark Salter > > > > > > > > The a

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-04 Thread Bjorn Helgaas
On Wed, Feb 4, 2015 at 4:48 AM, Russell King - ARM Linux wrote: > Moreover, __weak is positively harmful when you consider it adds bloat > and dead code - the overriden __weak function is left behind in the > resulting final image. Huh, I didn't realize that. Is that a linker bug, or is there so

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-04 Thread Rafael J. Wysocki
On Wednesday, February 04, 2015 10:48:32 AM Russell King - ARM Linux wrote: > On Tue, Feb 03, 2015 at 11:04:27PM +0100, Rafael J. Wysocki wrote: > > On Tuesday, February 03, 2015 12:29:36 PM Mark Salter wrote: > > > On Mon, 2015-02-02 at 23:14 +0100, Rafael J. Wysocki wrote: > > > > On Monday, Febr

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-04 Thread Catalin Marinas
On Tue, Feb 03, 2015 at 05:29:36PM +, Mark Salter wrote: > On Mon, 2015-02-02 at 23:14 +0100, Rafael J. Wysocki wrote: > > On Monday, February 02, 2015 08:45:30 PM Hanjun Guo wrote: > > > From: Mark Salter > > > > > > The acpi_os_ioremap() function may be used to map normal RAM or IO > > > re

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-04 Thread Russell King - ARM Linux
On Tue, Feb 03, 2015 at 11:04:27PM +0100, Rafael J. Wysocki wrote: > On Tuesday, February 03, 2015 12:29:36 PM Mark Salter wrote: > > On Mon, 2015-02-02 at 23:14 +0100, Rafael J. Wysocki wrote: > > > On Monday, February 02, 2015 08:45:30 PM Hanjun Guo wrote: > > > > From: Mark Salter > > > > > >

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-03 Thread Rafael J. Wysocki
On Tuesday, February 03, 2015 12:29:36 PM Mark Salter wrote: > On Mon, 2015-02-02 at 23:14 +0100, Rafael J. Wysocki wrote: > > On Monday, February 02, 2015 08:45:30 PM Hanjun Guo wrote: > > > From: Mark Salter > > > > > > The acpi_os_ioremap() function may be used to map normal RAM or IO > > > re

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-03 Thread Mark Salter
On Mon, 2015-02-02 at 23:14 +0100, Rafael J. Wysocki wrote: > On Monday, February 02, 2015 08:45:30 PM Hanjun Guo wrote: > > From: Mark Salter > > > > The acpi_os_ioremap() function may be used to map normal RAM or IO > > regions. The current implementation simply uses ioremap_cache(). This > > w

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-03 Thread Ard Biesheuvel
On 3 February 2015 at 11:37, Catalin Marinas wrote: > On Tue, Feb 03, 2015 at 09:08:42AM +, Hanjun Guo wrote: >> On 2015年02月03日 06:14, Rafael J. Wysocki wrote: >> > On Monday, February 02, 2015 08:45:30 PM Hanjun Guo wrote: >> >> From: Mark Salter >> >> >> >> The acpi_os_ioremap() function ma

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-03 Thread Catalin Marinas
On Tue, Feb 03, 2015 at 09:08:42AM +, Hanjun Guo wrote: > On 2015年02月03日 06:14, Rafael J. Wysocki wrote: > > On Monday, February 02, 2015 08:45:30 PM Hanjun Guo wrote: > >> From: Mark Salter > >> > >> The acpi_os_ioremap() function may be used to map normal RAM or IO > >> regions. The current

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-03 Thread Hanjun Guo
On 2015年02月03日 06:14, Rafael J. Wysocki wrote: On Monday, February 02, 2015 08:45:30 PM Hanjun Guo wrote: From: Mark Salter The acpi_os_ioremap() function may be used to map normal RAM or IO regions. The current implementation simply uses ioremap_cache(). This will work for some architectures,

Re: [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-02 Thread Rafael J. Wysocki
On Monday, February 02, 2015 08:45:30 PM Hanjun Guo wrote: > From: Mark Salter > > The acpi_os_ioremap() function may be used to map normal RAM or IO > regions. The current implementation simply uses ioremap_cache(). This > will work for some architectures, but arm64 ioremap_cache() cannot be > u

[PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

2015-02-02 Thread Hanjun Guo
From: Mark Salter The acpi_os_ioremap() function may be used to map normal RAM or IO regions. The current implementation simply uses ioremap_cache(). This will work for some architectures, but arm64 ioremap_cache() cannot be used to map IO regions which don't support caching. So for arm64, use io