Re: [PATCH v8 02/10] Makefile: Prepare for using macros for inline asm

2018-10-03 Thread Nadav Amit
at 12:43 PM, h...@zytor.com wrote: > > Does -pipe actually win anything these days? Sorry, I don’t have the time to check it right now. Anyhow, I presume it is best that such a change will be in a separate patch.

Re: [PATCH v8 02/10] Makefile: Prepare for using macros for inline asm

2018-10-03 Thread hpa
On October 2, 2018 3:59:52 AM PDT, Ingo Molnar wrote: > >* Nadav Amit wrote: > >> at 1:58 AM, Rasmus Villemoes wrote: >> >> > On 2018-09-18 23:28, Nadav Amit wrote: >> > >> >> diff --git a/arch/x86/Makefile b/arch/x86/Makefile >> >> index 8f6e7eb8ae9f..944fa3bc9376 100644 >> >> --- a/arch/x86/

Re: [PATCH v8 02/10] Makefile: Prepare for using macros for inline asm

2018-10-03 Thread Nadav Amit
at 3:01 PM, Masahiro Yamada wrote: > Hi. Thanks for your reply. Your advices are always valuable! > > > > 2018年9月27日(木) 2:57 Nadav Amit : >> at 1:58 AM, Rasmus Villemoes wrote: >> >>> On 2018-09-18 23:28, Nadav Amit wrote: >>> diff --git a/arch/x86/Makefile b/arch/x86/Makefile i

Re: [PATCH v8 02/10] Makefile: Prepare for using macros for inline asm

2018-10-02 Thread Ingo Molnar
* Nadav Amit wrote: > at 1:58 AM, Rasmus Villemoes wrote: > > > On 2018-09-18 23:28, Nadav Amit wrote: > > > >> diff --git a/arch/x86/Makefile b/arch/x86/Makefile > >> index 8f6e7eb8ae9f..944fa3bc9376 100644 > >> --- a/arch/x86/Makefile > >> +++ b/arch/x86/Makefile > >> @@ -214,8 +214,8 @@ i

Re: [PATCH v8 02/10] Makefile: Prepare for using macros for inline asm

2018-10-01 Thread Masahiro Yamada
Hi. 2018年9月27日(木) 2:57 Nadav Amit : > > at 1:58 AM, Rasmus Villemoes wrote: > > > On 2018-09-18 23:28, Nadav Amit wrote: > > > >> diff --git a/arch/x86/Makefile b/arch/x86/Makefile > >> index 8f6e7eb8ae9f..944fa3bc9376 100644 > >> --- a/arch/x86/Makefile > >> +++ b/arch/x86/Makefile > >> @@ -21

Re: [PATCH v8 02/10] Makefile: Prepare for using macros for inline asm

2018-09-27 Thread Rasmus Villemoes
On 2018-09-26 19:56, Nadav Amit wrote: > at 1:58 AM, Rasmus Villemoes wrote: > >>> +ASM_MACRO_FLAGS = -Wa,arch/x86/kernel/macros.s >>> +export ASM_MACRO_FLAGS >>> +KBUILD_CFLAGS += $(ASM_MACRO_FLAGS) >> How does this affect what gets rebuilt when one of the asm/foo.h files >> going into macros.s

Re: [PATCH v8 02/10] Makefile: Prepare for using macros for inline asm

2018-09-26 Thread Nadav Amit
at 1:58 AM, Rasmus Villemoes wrote: > On 2018-09-18 23:28, Nadav Amit wrote: > >> diff --git a/arch/x86/Makefile b/arch/x86/Makefile >> index 8f6e7eb8ae9f..944fa3bc9376 100644 >> --- a/arch/x86/Makefile >> +++ b/arch/x86/Makefile >> @@ -214,8 +214,8 @@ ifdef CONFIG_X86_64 >> KBUILD_LDFLAGS += $(

Re: [PATCH v8 02/10] Makefile: Prepare for using macros for inline asm

2018-09-26 Thread Rasmus Villemoes
On 2018-09-18 23:28, Nadav Amit wrote: > diff --git a/arch/x86/Makefile b/arch/x86/Makefile > index 8f6e7eb8ae9f..944fa3bc9376 100644 > --- a/arch/x86/Makefile > +++ b/arch/x86/Makefile > @@ -214,8 +214,8 @@ ifdef CONFIG_X86_64 > KBUILD_LDFLAGS += $(call ld-option, -z max-page-size=0x20) > e

[PATCH v8 02/10] Makefile: Prepare for using macros for inline asm

2018-09-18 Thread Nadav Amit
Using macros for inline assembly improves both readability and compilation decisions that are distorted by big assembly blocks that use alternative sections. Compile macros.S and use it to assemble all C files. Currently, only x86 will use it. Cc: Sam Ravnborg Cc: Michal Marek Cc: Thomas Gleixne