Re: [PATCH v8] input: keyboard: Add keys driver for the LPC32xx SoC

2012-07-10 Thread Roland Stigge
Hi Dmitry, On 10/07/12 18:41, Dmitry Torokhov wrote: > Ah, right, I meant to change that too ;) > > Could you please try this one for me (instead of the previous one)? Same problem (you actually sent the same patch). I'm posting an updated version considering all your suggestions from your last

Re: [PATCH v8] input: keyboard: Add keys driver for the LPC32xx SoC

2012-07-10 Thread Dmitry Torokhov
On Tue, Jul 10, 2012 at 11:36:25AM +0200, Roland Stigge wrote: > Hi Dmitry! > > On 07/10/2012 08:36 AM, Dmitry Torokhov wrote: > >> +static void lpc32xx_mod_states(struct lpc32xx_kscan_drv *kscandat, int > >> col) > >> +{ > >> + u8 key; > >> + int row; > >> + unsigned changed, scancode, keycod

Re: [PATCH v8] input: keyboard: Add keys driver for the LPC32xx SoC

2012-07-10 Thread Roland Stigge
Hi Dmitry! On 07/10/2012 08:36 AM, Dmitry Torokhov wrote: >> +static void lpc32xx_mod_states(struct lpc32xx_kscan_drv *kscandat, int col) >> +{ >> +u8 key; >> +int row; >> +unsigned changed, scancode, keycode; >> + >> +key = readl(LPC32XX_KS_DATA(kscandat->kscan_base, col)); >> +

Re: [PATCH v8] input: keyboard: Add keys driver for the LPC32xx SoC

2012-07-09 Thread Dmitry Torokhov
Hi Roland, On Thu, Jun 28, 2012 at 12:03:16AM +0200, Roland Stigge wrote: > + > +struct lpc32xx_kscan_drv { > + struct input_dev *input; > + struct clk *clk; > + void __iomem *kscan_base; > + u8 lastkeystates[8]; > + u32 io_p_start; > + u32 io_p_size; > + u32 matrix_sz;