Re: [PATCH v7 net-next 2/2] net: dsa: qca: ar9331: export stats64

2021-01-11 Thread Oleksij Rempel
On Sat, Jan 09, 2021 at 02:21:43AM +0200, Vladimir Oltean wrote: > On Fri, Jan 08, 2021 at 06:32:28AM +0100, Oleksij Rempel wrote: > > May be the "net: dsa: add optional stats64 support" can already be > > taken? > > I'm not sure that I see the point. David and Jakub won't cherry-pick > partial se

Re: [PATCH v7 net-next 2/2] net: dsa: qca: ar9331: export stats64

2021-01-09 Thread Jakub Kicinski
On Thu, 7 Jan 2021 15:36:45 +0100 Andrew Lunn wrote: > > +static void ar9331_get_stats64(struct dsa_switch *ds, int port, > > + struct rtnl_link_stats64 *s) > > +{ > > + struct ar9331_sw_priv *priv = (struct ar9331_sw_priv *)ds->priv; > > + struct ar9331_sw_port *p = &p

Re: [PATCH v7 net-next 2/2] net: dsa: qca: ar9331: export stats64

2021-01-08 Thread Vladimir Oltean
On Fri, Jan 08, 2021 at 06:32:28AM +0100, Oleksij Rempel wrote: > May be the "net: dsa: add optional stats64 support" can already be > taken? I'm not sure that I see the point. David and Jakub won't cherry-pick partial series, and if you resend just patch 1/2, they won't accept new code that doesn

Re: [PATCH v7 net-next 2/2] net: dsa: qca: ar9331: export stats64

2021-01-07 Thread Oleksij Rempel
On Thu, Jan 07, 2021 at 03:36:45PM +0100, Andrew Lunn wrote: > > +static void ar9331_get_stats64(struct dsa_switch *ds, int port, > > + struct rtnl_link_stats64 *s) > > +{ > > + struct ar9331_sw_priv *priv = (struct ar9331_sw_priv *)ds->priv; > > + struct ar9331_sw_port

Re: [PATCH v7 net-next 2/2] net: dsa: qca: ar9331: export stats64

2021-01-07 Thread Andrew Lunn
> +static void ar9331_get_stats64(struct dsa_switch *ds, int port, > +struct rtnl_link_stats64 *s) > +{ > + struct ar9331_sw_priv *priv = (struct ar9331_sw_priv *)ds->priv; > + struct ar9331_sw_port *p = &priv->port[port]; > + > + spin_lock(&p->stats_lock); >

[PATCH v7 net-next 2/2] net: dsa: qca: ar9331: export stats64

2021-01-07 Thread Oleksij Rempel
Add stats support for the ar9331 switch. Signed-off-by: Oleksij Rempel --- drivers/net/dsa/qca/ar9331.c | 164 ++- 1 file changed, 163 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/qca/ar9331.c b/drivers/net/dsa/qca/ar9331.c index 4d49c5f2b790..1a1584