Re: [PATCH v7 5/6] pci: Export find_pci_host_bridge() function.

2014-04-07 Thread One Thousand Gnomes
> > If we *do* export it, I'd like it to have a more conventional name, e.g., > > something starting with "pci_". > > Understood. pci_find_host_bridge() ? pci_get_host_bridge() and take a reference IMHO ? If your primary bus is not PCI then your PCI "host" bridge could be hot swappable so the API

Re: [PATCH v7 5/6] pci: Export find_pci_host_bridge() function.

2014-04-07 Thread Liviu Dudau
On Sat, Apr 05, 2014 at 12:39:48AM +0100, Bjorn Helgaas wrote: > On Fri, Mar 14, 2014 at 03:34:31PM +, Liviu Dudau wrote: > > This is a useful function and we should make it visible outside the > > generic PCI code. Export it as a GPL symbol. > > > > Signed-off-by: Liviu Dudau > > Tested-by:

Re: [PATCH v7 5/6] pci: Export find_pci_host_bridge() function.

2014-04-04 Thread Bjorn Helgaas
On Fri, Mar 14, 2014 at 03:34:31PM +, Liviu Dudau wrote: > This is a useful function and we should make it visible outside the > generic PCI code. Export it as a GPL symbol. > > Signed-off-by: Liviu Dudau > Tested-by: Tanmay Inamdar > --- > drivers/pci/host-bridge.c | 3 ++- > 1 file change

[PATCH v7 5/6] pci: Export find_pci_host_bridge() function.

2014-03-14 Thread Liviu Dudau
This is a useful function and we should make it visible outside the generic PCI code. Export it as a GPL symbol. Signed-off-by: Liviu Dudau Tested-by: Tanmay Inamdar --- drivers/pci/host-bridge.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pci/host-bridge.c b/d