Re: [PATCH v7 3/5] phy: Add set_vbus callback

2017-01-24 Thread Kishon Vijay Abraham I
Hi, On Tuesday 24 January 2017 01:28 AM, Stephen Boyd wrote: > Quoting Kishon Vijay Abraham I (2017-01-22 00:46:21) >> Hi, >> >> On Saturday 21 January 2017 12:20 AM, Stephen Boyd wrote: >>> Some USB PHYs need to be told about vbus changing state >>> explicitly. For example the qcom USB HS PHY nee

Re: [PATCH v7 3/5] phy: Add set_vbus callback

2017-01-23 Thread Stephen Boyd
Quoting Kishon Vijay Abraham I (2017-01-22 00:46:21) > Hi, > > On Saturday 21 January 2017 12:20 AM, Stephen Boyd wrote: > > Some USB PHYs need to be told about vbus changing state > > explicitly. For example the qcom USB HS PHY needs to toggle a bit > > when vbus goes from low to high (VBUSVLDEXT

Re: [PATCH v7 3/5] phy: Add set_vbus callback

2017-01-22 Thread Kishon Vijay Abraham I
Hi, On Saturday 21 January 2017 12:20 AM, Stephen Boyd wrote: > Some USB PHYs need to be told about vbus changing state > explicitly. For example the qcom USB HS PHY needs to toggle a bit > when vbus goes from low to high (VBUSVLDEXT) to cause the > "session valid" signal to toggle. This signal wi

RE: [PATCH v7 3/5] phy: Add set_vbus callback

2017-01-21 Thread Peter Chen
> * @set_mode: set the mode of the phy >+ * @set_vbus: enable/disable vbus in the phy (USB) > * @reset: resetting the phy > * @owner: the module owner containing the ops > */ >@@ -45,6 +46,7 @@ struct phy_ops { > int (*power_on)(struct phy *phy); > int (*power_off)(struct

[PATCH v7 3/5] phy: Add set_vbus callback

2017-01-20 Thread Stephen Boyd
Some USB PHYs need to be told about vbus changing state explicitly. For example the qcom USB HS PHY needs to toggle a bit when vbus goes from low to high (VBUSVLDEXT) to cause the "session valid" signal to toggle. This signal will pull up D+ when the phy starts running. If the vbus signal isn't rou