Re: [PATCH v7 3/3] gpio: pca953x: fix address calculation for pcal6524

2018-06-06 Thread Pavel Machek
On Wed 2018-06-06 07:33:32, H. Nikolaus Schaller wrote: > Hi, > > > Am 05.06.2018 um 22:39 schrieb Pavel Machek : > > > > On Tue 2018-06-05 18:37:21, Andy Shevchenko wrote: > >> On Wed, May 23, 2018 at 5:06 PM, Pavel Machek wrote: > >>> On Thu 2018-05-17 06:59:49, H. Nikolaus Schaller wrote: > >

Re: [PATCH v7 3/3] gpio: pca953x: fix address calculation for pcal6524

2018-06-05 Thread H. Nikolaus Schaller
Hi, > Am 05.06.2018 um 22:39 schrieb Pavel Machek : > > On Tue 2018-06-05 18:37:21, Andy Shevchenko wrote: >> On Wed, May 23, 2018 at 5:06 PM, Pavel Machek wrote: >>> On Thu 2018-05-17 06:59:49, H. Nikolaus Schaller wrote: The register constants are so far defined in a way that they fit >>>

Re: [PATCH v7 3/3] gpio: pca953x: fix address calculation for pcal6524

2018-06-05 Thread Pavel Machek
On Tue 2018-06-05 18:37:21, Andy Shevchenko wrote: > On Wed, May 23, 2018 at 5:06 PM, Pavel Machek wrote: > > On Thu 2018-05-17 06:59:49, H. Nikolaus Schaller wrote: > >> The register constants are so far defined in a way that they fit > >> for the pcal9555a when shifted by the number of banks, i.

Re: [PATCH v7 3/3] gpio: pca953x: fix address calculation for pcal6524

2018-06-05 Thread Andy Shevchenko
On Wed, May 23, 2018 at 5:06 PM, Pavel Machek wrote: > On Thu 2018-05-17 06:59:49, H. Nikolaus Schaller wrote: >> The register constants are so far defined in a way that they fit >> for the pcal9555a when shifted by the number of banks, i.e. are >> multiplied by 2 in the accessor function. >> >> N

Re: [PATCH v7 3/3] gpio: pca953x: fix address calculation for pcal6524

2018-05-23 Thread Pavel Machek
On Thu 2018-05-17 06:59:49, H. Nikolaus Schaller wrote: > The register constants are so far defined in a way that they fit > for the pcal9555a when shifted by the number of banks, i.e. are > multiplied by 2 in the accessor function. > > Now, the pcal6524 has 3 banks which means the relative offset

Re: [PATCH v7 3/3] gpio: pca953x: fix address calculation for pcal6524

2018-05-23 Thread Linus Walleij
On Thu, May 17, 2018 at 6:59 AM, H. Nikolaus Schaller wrote: > The register constants are so far defined in a way that they fit > for the pcal9555a when shifted by the number of banks, i.e. are > multiplied by 2 in the accessor function. > > Now, the pcal6524 has 3 banks which means the relative

[PATCH v7 3/3] gpio: pca953x: fix address calculation for pcal6524

2018-05-16 Thread H. Nikolaus Schaller
The register constants are so far defined in a way that they fit for the pcal9555a when shifted by the number of banks, i.e. are multiplied by 2 in the accessor function. Now, the pcal6524 has 3 banks which means the relative offset is multiplied by 4 for the standard registers. Simply applying t