Re: [PATCH v7 2/4] uprobe: use original page when all uprobes are removed

2019-07-24 Thread Oleg Nesterov
On 07/24, Song Liu wrote: > > > > On Jul 15, 2019, at 8:25 AM, Oleg Nesterov wrote: > > > >> + if (!is_register) { > >> + struct page *orig_page; > >> + pgoff_t index; > >> + > >> + index = vaddr_to_offset(vma, vaddr & PAGE_MASK) >> PAGE_SHIFT; > >> + orig_page

Re: [PATCH v7 2/4] uprobe: use original page when all uprobes are removed

2019-07-24 Thread Song Liu
> On Jul 15, 2019, at 8:25 AM, Oleg Nesterov wrote: > > On 06/25, Song Liu wrote: >> >> This patch allows uprobe to use original page when possible (all uprobes >> on the page are already removed). > > I can't review. I do not understand vm enough. > >> +if (!is_register) { >> +

Re: [PATCH v7 2/4] uprobe: use original page when all uprobes are removed

2019-07-15 Thread Oleg Nesterov
On 06/25, Song Liu wrote: > > This patch allows uprobe to use original page when possible (all uprobes > on the page are already removed). I can't review. I do not understand vm enough. > + if (!is_register) { > + struct page *orig_page; > + pgoff_t index; > + > +

Re: [PATCH v7 2/4] uprobe: use original page when all uprobes are removed

2019-06-25 Thread Srikar Dronamraju
* Song Liu [2019-06-25 16:53:23]: > Currently, uprobe swaps the target page with a anonymous page in both > install_breakpoint() and remove_breakpoint(). When all uprobes on a page > are removed, the given mm is still using an anonymous page (not the > original page). > > This patch allows uprob

[PATCH v7 2/4] uprobe: use original page when all uprobes are removed

2019-06-25 Thread Song Liu
Currently, uprobe swaps the target page with a anonymous page in both install_breakpoint() and remove_breakpoint(). When all uprobes on a page are removed, the given mm is still using an anonymous page (not the original page). This patch allows uprobe to use original page when possible (all uprobe