Re: [PATCH v7 2/3] serial: exar: split out the exar code from 8250_pci

2017-01-08 Thread Sudip Mukherjee
On Sunday 08 January 2017 01:02 AM, Andy Shevchenko wrote: On Sun, Jan 8, 2017 at 1:57 AM, Sudip Mukherjee wrote: Add the serial driver for the exar chips. And also register the platform device for the exar gpio. Did you ignore some comments? IIRC I recommended to use proper vendor name like

Re: [PATCH v7 2/3] serial: exar: split out the exar code from 8250_pci

2017-01-07 Thread Andy Shevchenko
On Sun, Jan 8, 2017 at 1:57 AM, Sudip Mukherjee wrote: > Add the serial driver for the exar chips. And also register the > platform device for the exar gpio. Did you ignore some comments? IIRC I recommended to use proper vendor name like Exar (or how is it spelled?). > Headers, if arranged in a

[PATCH v7 2/3] serial: exar: split out the exar code from 8250_pci

2017-01-07 Thread Sudip Mukherjee
Add the serial driver for the exar chips. And also register the platform device for the exar gpio. Signed-off-by: Sudip Mukherjee --- Hi Andy, Headers, if arranged in alphabetical order, will give a build warning. And thanks for revewing that v6. I think those were the worst patch I have ever po