Re: [PATCH v7 2/3] aerdrv: Enhanced AER logging

2012-12-26 Thread Bjorn Helgaas
On Wed, Dec 5, 2012 at 9:30 AM, Borislav Petkov wrote: > On Wed, Dec 05, 2012 at 04:14:14PM +, Ortiz, Lance E wrote: >> I removed the prefix argument because it was never used by its caller >> and never set. The reason I added the prefix variable and set it to >> NULL was to help in breaking u

Re: [PATCH v7 2/3] aerdrv: Enhanced AER logging

2012-12-05 Thread Borislav Petkov
On Wed, Dec 05, 2012 at 04:14:14PM +, Ortiz, Lance E wrote: > I removed the prefix argument because it was never used by its caller > and never set. The reason I added the prefix variable and set it to > NULL was to help in breaking up the patch and adding it would help the > intermittent patch

RE: [PATCH v7 2/3] aerdrv: Enhanced AER logging

2012-12-05 Thread Ortiz, Lance E
> > + char *prefix = NULL; > > What are you doing here? You dropped the 'prefix' argument being passed > down in this function and are defining a local variable of the same > name > which is used in the function later: > > printk("%s""aer_status: 0x%08x, aer_mask: 0x%08x\n", >

Re: [PATCH v7 2/3] aerdrv: Enhanced AER logging

2012-12-05 Thread Borislav Petkov
On Tue, Dec 04, 2012 at 02:03:12PM -0700, Lance Ortiz wrote: > This patch will provide a more reliable and easy way for user-space > applications to have access to AER logs rather than reading them from the > message buffer. It also provides a way to notify user-space when an AER > event occurs. >

[PATCH v7 2/3] aerdrv: Enhanced AER logging

2012-12-04 Thread Lance Ortiz
This patch will provide a more reliable and easy way for user-space applications to have access to AER logs rather than reading them from the message buffer. It also provides a way to notify user-space when an AER event occurs. The aer driver is updated to generate a trace event of function 'aer_e