Re: [PATCH v7 15/17] media: uvcvideo: Refactor __uvc_ctrl_commit

2021-03-19 Thread Ricardo Ribalda Delgado
Hello Hans On Fri, Mar 19, 2021 at 9:35 AM Hans Verkuil wrote: > > On 18/03/2021 21:29, Ricardo Ribalda wrote: > > Take a v4l2_ext_controls instead of an array of controls, this way we > > can access the error_idx in future changes. > > > > Signed-off-by: Ricardo Ribalda > > --- > > drivers/me

Re: [PATCH v7 15/17] media: uvcvideo: Refactor __uvc_ctrl_commit

2021-03-19 Thread Hans Verkuil
On 18/03/2021 21:29, Ricardo Ribalda wrote: > Take a v4l2_ext_controls instead of an array of controls, this way we > can access the error_idx in future changes. > > Signed-off-by: Ricardo Ribalda > --- > drivers/media/usb/uvc/uvc_ctrl.c | 5 ++--- > drivers/media/usb/uvc/uvc_v4l2.c | 8 ++

[PATCH v7 15/17] media: uvcvideo: Refactor __uvc_ctrl_commit

2021-03-18 Thread Ricardo Ribalda
Take a v4l2_ext_controls instead of an array of controls, this way we can access the error_idx in future changes. Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_ctrl.c | 5 ++--- drivers/media/usb/uvc/uvc_v4l2.c | 8 ++-- drivers/media/usb/uvc/uvcvideo.h | 10 -- 3 fi