RE: [PATCH v7 12/14] cpufreq: Add Kryo CPU scaling driver

2018-05-17 Thread ilialin
linux- > c...@vger.kernel.org' ; > 'devicet...@vger.kernel.org' ; 'LKML' ker...@vger.kernel.org>; 'Linux PM list' ; 'linux- > arm-...@vger.kernel.org' ; 'linux- > s...@vger.kernel.org' ; 'lakml' ker...@lists.infradead.org&

RE: [PATCH v7 12/14] cpufreq: Add Kryo CPU scaling driver

2018-05-17 Thread ilialin
..@linaro.org; > cels...@codeaurora.org; tfin...@codeaurora.org > Subject: Re: [PATCH v7 12/14] cpufreq: Add Kryo CPU scaling driver > > On 16-05-18, 16:12, Amit Kucheria wrote: > > > + ret = PTR_ERR_OR_ZERO(opp_temp = > > > + > dev_pm_opp_set_supported_hw(cpu_dev,&ver

RE: [PATCH v7 12/14] cpufreq: Add Kryo CPU scaling driver

2018-05-17 Thread ilialin
nel.org; lakml ker...@lists.infradead.org>; Rajendra Nayak ; > nicolas.deche...@linaro.org; cels...@codeaurora.org; > tfin...@codeaurora.org > Subject: Re: [PATCH v7 12/14] cpufreq: Add Kryo CPU scaling driver > > On Tue, May 15, 2018 at 12:13 PM, Ilia Lin wrote: >

Re: [PATCH v7 12/14] cpufreq: Add Kryo CPU scaling driver

2018-05-16 Thread Amit Kucheria
On Wed, May 16, 2018 at 5:11 PM, Viresh Kumar wrote: > On 16-05-18, 16:12, Amit Kucheria wrote: >> > + ret = PTR_ERR_OR_ZERO(opp_temp = >> > + >> > dev_pm_opp_set_supported_hw(cpu_dev,&versions,1)); >> > + if (0 > ret) >> >> Any particular reason to prefer

Re: [PATCH v7 12/14] cpufreq: Add Kryo CPU scaling driver

2018-05-16 Thread Viresh Kumar
On 16-05-18, 16:12, Amit Kucheria wrote: > > + ret = PTR_ERR_OR_ZERO(opp_temp = > > + > > dev_pm_opp_set_supported_hw(cpu_dev,&versions,1)); > > + if (0 > ret) > > Any particular reason to prefer this over (ret < 0) that is generally > used? I've seen it us

Re: [PATCH v7 12/14] cpufreq: Add Kryo CPU scaling driver

2018-05-16 Thread Amit Kucheria
On Tue, May 15, 2018 at 12:13 PM, Ilia Lin wrote: > In Certain QCOM SoCs like apq8096 and msm8996 that have KRYO processors, > the CPU ferequencies subset and voltage value of each OPP varies s/ferequencies/frequency > based on the silicon variant in use. Qualcomm Process Voltage Scaling Tables

Re: [PATCH v7 12/14] cpufreq: Add Kryo CPU scaling driver

2018-05-15 Thread kbuild test robot
Hi Ilia, Thank you for the patch! Yet something to improve: [auto build test ERROR on robh/for-next] [also build test ERROR on v4.17-rc5] [cannot apply to clk/clk-next next-20180515] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: http

Re: [PATCH v7 12/14] cpufreq: Add Kryo CPU scaling driver

2018-05-15 Thread Rafael J. Wysocki
On Tuesday, May 15, 2018 11:19:12 AM CEST Viresh Kumar wrote: > On 15-05-18, 12:13, Ilia Lin wrote: > > In Certain QCOM SoCs like apq8096 and msm8996 that have KRYO processors, > > the CPU ferequencies subset and voltage value of each OPP varies > > based on the silicon variant in use. Qualcomm Pro

Re: [PATCH v7 12/14] cpufreq: Add Kryo CPU scaling driver

2018-05-15 Thread Viresh Kumar
On 15-05-18, 12:13, Ilia Lin wrote: > In Certain QCOM SoCs like apq8096 and msm8996 that have KRYO processors, > the CPU ferequencies subset and voltage value of each OPP varies > based on the silicon variant in use. Qualcomm Process Voltage Scaling Tables > defines the voltage and frequency value

[PATCH v7 12/14] cpufreq: Add Kryo CPU scaling driver

2018-05-15 Thread Ilia Lin
In Certain QCOM SoCs like apq8096 and msm8996 that have KRYO processors, the CPU ferequencies subset and voltage value of each OPP varies based on the silicon variant in use. Qualcomm Process Voltage Scaling Tables defines the voltage and frequency value based on the msm-id in SMEM and speedbin blo