Re: [PATCH v7 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-10-03 Thread Viktor Rosendahl
On 10/2/19 2:32 AM, Joel Fernandes wrote: Some nits, but others looks good: On Fri, Sep 20, 2019 at 05:22:16PM +0200, Viktor Rosendahl (BMW) wrote: This patch implements the feature that the tracing_max_latency file, e.g. /sys/kernel/debug/tracing/tracing_max_latency will receive notifications

Re: [PATCH v7 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-10-02 Thread Steven Rostedt
On Thu, 3 Oct 2019 00:04:56 +0200 Viktor Rosendahl wrote: > > Can fsnotify() be called from irq context? If so, why have the work > > queue at all? Just do the work from the irq_work handler. > > > > fsnotify() might sleep. It calls send_to_group(), which calls > inotify_handle_event() throu

Re: [PATCH v7 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-10-02 Thread Viktor Rosendahl
On 10/2/19 5:13 PM, Steven Rostedt wrote: On Fri, 20 Sep 2019 17:22:16 +0200 "Viktor Rosendahl (BMW)" wrote: This patch implements the feature that the tracing_max_latency file, e.g. /sys/kernel/debug/tracing/tracing_max_latency will receive notifications through the fsnotify framework when a

Re: [PATCH v7 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-10-02 Thread Steven Rostedt
On Fri, 20 Sep 2019 17:22:16 +0200 "Viktor Rosendahl (BMW)" wrote: > This patch implements the feature that the tracing_max_latency file, > e.g. /sys/kernel/debug/tracing/tracing_max_latency will receive > notifications through the fsnotify framework when a new latency is > available. > > One pa

Re: [PATCH v7 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-10-01 Thread Joel Fernandes
Some nits, but others looks good: On Fri, Sep 20, 2019 at 05:22:16PM +0200, Viktor Rosendahl (BMW) wrote: > This patch implements the feature that the tracing_max_latency file, > e.g. /sys/kernel/debug/tracing/tracing_max_latency will receive > notifications through the fsnotify framework when a n

[PATCH v7 1/4] ftrace: Implement fs notification for tracing_max_latency

2019-09-20 Thread Viktor Rosendahl (BMW)
This patch implements the feature that the tracing_max_latency file, e.g. /sys/kernel/debug/tracing/tracing_max_latency will receive notifications through the fsnotify framework when a new latency is available. One particularly interesting use of this facility is when enabling threshold tracing, t