Re: [PATCH v7 1/4] KEYS: trusted: Add generic trusted keys framework

2020-10-22 Thread Sumit Garg
On Wed, 21 Oct 2020 at 17:55, Mimi Zohar wrote: > > On Wed, 2020-10-21 at 11:16 +0530, Sumit Garg wrote: > > Thanks Mimi for your comments. > > > > On Wed, 21 Oct 2020 at 08:51, Mimi Zohar wrote: > > > > > > On Wed, 2020-10-07 at 15:37 +0530, Sumit Garg wrote: > > > > > > > +/* > > > > + * truste

Re: [PATCH v7 1/4] KEYS: trusted: Add generic trusted keys framework

2020-10-21 Thread Mimi Zohar
On Wed, 2020-10-21 at 11:16 +0530, Sumit Garg wrote: > Thanks Mimi for your comments. > > On Wed, 21 Oct 2020 at 08:51, Mimi Zohar wrote: > > > > On Wed, 2020-10-07 at 15:37 +0530, Sumit Garg wrote: > > > > > +/* > > > + * trusted_destroy - clear and free the key's payload > > > + */ > > > +stati

Re: [PATCH v7 1/4] KEYS: trusted: Add generic trusted keys framework

2020-10-20 Thread Sumit Garg
Thanks Mimi for your comments. On Wed, 21 Oct 2020 at 08:51, Mimi Zohar wrote: > > On Wed, 2020-10-07 at 15:37 +0530, Sumit Garg wrote: > > > +/* > > + * trusted_destroy - clear and free the key's payload > > + */ > > +static void trusted_destroy(struct key *key) > > +{ > > + kfree_sensitive(

Re: [PATCH v7 1/4] KEYS: trusted: Add generic trusted keys framework

2020-10-20 Thread Mimi Zohar
On Wed, 2020-10-07 at 15:37 +0530, Sumit Garg wrote: > +/* > + * trusted_destroy - clear and free the key's payload > + */ > +static void trusted_destroy(struct key *key) > +{ > + kfree_sensitive(key->payload.data[0]); > +} > + > +struct key_type key_type_trusted = { > + .name = "trusted",

Re: [PATCH v7 1/4] KEYS: trusted: Add generic trusted keys framework

2020-10-14 Thread Sumit Garg
On Tue, 13 Oct 2020 at 17:29, Jarkko Sakkinen wrote: > > On Tue, Oct 13, 2020 at 04:23:36PM +0530, Sumit Garg wrote: > > On Tue, 13 Oct 2020 at 07:13, Jarkko Sakkinen > > wrote: > > > > > > On Wed, Oct 07, 2020 at 03:37:45PM +0530, Sumit Garg wrote: > > > > Current trusted keys framework is tight

Re: [PATCH v7 1/4] KEYS: trusted: Add generic trusted keys framework

2020-10-13 Thread Jarkko Sakkinen
On Tue, Oct 13, 2020 at 04:23:36PM +0530, Sumit Garg wrote: > On Tue, 13 Oct 2020 at 07:13, Jarkko Sakkinen > wrote: > > > > On Wed, Oct 07, 2020 at 03:37:45PM +0530, Sumit Garg wrote: > > > Current trusted keys framework is tightly coupled to use TPM device as > > > an underlying implementation w

Re: [PATCH v7 1/4] KEYS: trusted: Add generic trusted keys framework

2020-10-13 Thread Sumit Garg
On Tue, 13 Oct 2020 at 07:13, Jarkko Sakkinen wrote: > > On Wed, Oct 07, 2020 at 03:37:45PM +0530, Sumit Garg wrote: > > Current trusted keys framework is tightly coupled to use TPM device as > > an underlying implementation which makes it difficult for implementations > > like Trusted Execution E

Re: [PATCH v7 1/4] KEYS: trusted: Add generic trusted keys framework

2020-10-12 Thread Jarkko Sakkinen
On Wed, Oct 07, 2020 at 03:37:45PM +0530, Sumit Garg wrote: > Current trusted keys framework is tightly coupled to use TPM device as > an underlying implementation which makes it difficult for implementations > like Trusted Execution Environment (TEE) etc. to provide trusted keys > support in case

[PATCH v7 1/4] KEYS: trusted: Add generic trusted keys framework

2020-10-07 Thread Sumit Garg
Current trusted keys framework is tightly coupled to use TPM device as an underlying implementation which makes it difficult for implementations like Trusted Execution Environment (TEE) etc. to provide trusted keys support in case platform doesn't posses a TPM device. Add a generic trusted keys fr