Re: [PATCH v7 1/2] serial: sc16is7xx

2014-04-25 Thread Alexander Shiyan
Fri, 25 Apr 2014 14:24:23 -0400 от Jon Ringle : > On Fri, Apr 25, 2014 at 1:40 PM, Alexander Shiyan wrote: > > Fri, 25 Apr 2014 10:26:40 -0700 от Greg KH : > >> On Thu, Apr 24, 2014 at 08:56:06PM -0400, j...@ringle.org wrote: > >> > From: Jon Ringle > >> > > >> > The SC16IS7xx is a slave I2C-bus/

Re: [PATCH v7 1/2] serial: sc16is7xx

2014-04-25 Thread Jon Ringle
On Fri, Apr 25, 2014 at 1:40 PM, Alexander Shiyan wrote: > Fri, 25 Apr 2014 10:26:40 -0700 от Greg KH : >> On Thu, Apr 24, 2014 at 08:56:06PM -0400, j...@ringle.org wrote: >> > From: Jon Ringle >> > >> > The SC16IS7xx is a slave I2C-bus/SPI interface to a single-channel >> > high performance UART

Re: [PATCH v7 1/2] serial: sc16is7xx

2014-04-25 Thread Alexander Shiyan
Fri, 25 Apr 2014 10:26:40 -0700 от Greg KH : > On Thu, Apr 24, 2014 at 08:56:06PM -0400, j...@ringle.org wrote: > > From: Jon Ringle > > > > The SC16IS7xx is a slave I2C-bus/SPI interface to a single-channel > > high performance UART. The SC16IS7xx's internal register set is > > backward-compatib

Re: [PATCH v7 1/2] serial: sc16is7xx

2014-04-25 Thread Greg KH
On Thu, Apr 24, 2014 at 08:56:06PM -0400, j...@ringle.org wrote: > From: Jon Ringle > > The SC16IS7xx is a slave I2C-bus/SPI interface to a single-channel > high performance UART. The SC16IS7xx's internal register set is > backward-compatible with the widely used and widely popular 16C450. > > T

Re: [PATCH v7 1/2] serial: sc16is7xx

2014-04-25 Thread One Thousand Gnomes
> Fair enough, but the 8250 framework does allow you to insert your own > irq service routine. "serial8250_default_handle_irq" is the default > (unsurprisingly), but if the uart_port has a non-NULL "handle_irq" > method it will be faithfully copied into the uart_8250_port > "handle_irq" method in 8

Re: [PATCH v7 1/2] serial: sc16is7xx

2014-04-25 Thread Jon Ringle
On Fri, Apr 25, 2014 at 10:24 AM, Charles Coldwell wrote: > On Fri, 25 Apr 2014, Jon Ringle wrote: > >> On Fri, Apr 25, 2014 at 9:44 AM, Charles Coldwell wrote: >> > On Fri, 25 Apr 2014, Charles Coldwell wrote: >> > >> >> On Thu, 24 Apr 2014, j...@ringle.org wrote: >> >> >> >> > diff --git a/driv

Re: [PATCH v7 1/2] serial: sc16is7xx

2014-04-25 Thread Charles Coldwell
On Fri, 25 Apr 2014, Alexander Shiyan wrote: > > At this stage, I would suggest just move the driver code into serial/8250 > to indicate the compatibility and then apply this patch and look for ways > to optimize similar functions. I suppose I could live with that. This is really a wonderful UA

Re: [PATCH v7 1/2] serial: sc16is7xx

2014-04-25 Thread Alexander Shiyan
Fri, 25 Apr 2014 10:24:30 -0400 (EDT) от Charles Coldwell : > On Fri, 25 Apr 2014, Jon Ringle wrote: > > > On Fri, Apr 25, 2014 at 9:44 AM, Charles Coldwell > > wrote: > > > On Fri, 25 Apr 2014, Charles Coldwell wrote: > > > > > >> On Thu, 24 Apr 2014, j...@ringle.org wrote: > > >> > > >> > diff

Re: [PATCH v7 1/2] serial: sc16is7xx

2014-04-25 Thread Charles Coldwell
On Fri, 25 Apr 2014, Jon Ringle wrote: > On Fri, Apr 25, 2014 at 9:44 AM, Charles Coldwell wrote: > > On Fri, 25 Apr 2014, Charles Coldwell wrote: > > > >> On Thu, 24 Apr 2014, j...@ringle.org wrote: > >> > >> > diff --git a/drivers/tty/serial/sc16is7xx.c > >> > b/drivers/tty/serial/sc16is7xx.c

Re: [PATCH v7 1/2] serial: sc16is7xx

2014-04-25 Thread Jon Ringle
On Fri, Apr 25, 2014 at 9:35 AM, Alexander Shiyan wrote: > And it would be nice to have a small changelog, > because it is unclear what has changed with version 6. v7 was created at Greg's request to refresh the patch. The only conflict that required code change was in serial_core.h changing #def

Re: [PATCH v7 1/2] serial: sc16is7xx

2014-04-25 Thread Jon Ringle
On Fri, Apr 25, 2014 at 9:44 AM, Charles Coldwell wrote: > On Fri, 25 Apr 2014, Charles Coldwell wrote: > >> On Thu, 24 Apr 2014, j...@ringle.org wrote: >> >> > diff --git a/drivers/tty/serial/sc16is7xx.c >> > b/drivers/tty/serial/sc16is7xx.c >> > new file mode 100644 >> > index 000..ed139f5

Re: [PATCH v7 1/2] serial: sc16is7xx

2014-04-25 Thread Charles Coldwell
On Fri, 25 Apr 2014, Charles Coldwell wrote: > On Thu, 24 Apr 2014, j...@ringle.org wrote: > > > diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c > > new file mode 100644 > > index 000..ed139f5 > > --- /dev/null > > +++ b/drivers/tty/serial/sc16is7xx.c > > > + > >

Re: [PATCH v7 1/2] serial: sc16is7xx

2014-04-25 Thread Alexander Shiyan
Fri, 25 Apr 2014 09:21:26 -0400 (EDT) от Charles Coldwell : > On Thu, 24 Apr 2014, j...@ringle.org wrote: > > > diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c > > new file mode 100644 > > index 000..ed139f5 > > --- /dev/null > > +++ b/drivers/tty/serial/sc16is7xx.

Re: [PATCH v7 1/2] serial: sc16is7xx

2014-04-25 Thread Charles Coldwell
On Thu, 24 Apr 2014, j...@ringle.org wrote: > diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c > new file mode 100644 > index 000..ed139f5 > --- /dev/null > +++ b/drivers/tty/serial/sc16is7xx.c > + > +/* SC16IS7XX register definitions */ > +#define SC16IS7XX_RHR_RE

[PATCH v7 1/2] serial: sc16is7xx

2014-04-24 Thread jon
From: Jon Ringle The SC16IS7xx is a slave I2C-bus/SPI interface to a single-channel high performance UART. The SC16IS7xx's internal register set is backward-compatible with the widely used and widely popular 16C450. The SC16IS7xx also provides additional advanced features such as auto hardware a