Re: [PATCH v7 08/22] Replace xip_truncate_page with dax_truncate_page

2014-04-13 Thread Matthew Wilcox
On Wed, Apr 09, 2014 at 11:26:35AM +0200, Jan Kara wrote: > I thought about this for a while and classical IO, truncation etc. could > easily work for blocksize < pagesize. And for mmap() you could just use > pagecache. Not sure if it's worth the complications though. Anyway we > should decide wh

Re: [PATCH v7 08/22] Replace xip_truncate_page with dax_truncate_page

2014-04-09 Thread Jan Kara
On Wed 09-04-14 00:17:59, Jan Kara wrote: > On Sun 23-03-14 15:08:34, Matthew Wilcox wrote: > > +/** > > + * dax_truncate_page - handle a partial page being truncated in a DAX file > > + * @inode: The file being truncated > > + * @from: The file offset that is being truncated to > > + * @get_block:

Re: [PATCH v7 08/22] Replace xip_truncate_page with dax_truncate_page

2014-04-08 Thread Jan Kara
On Sun 23-03-14 15:08:34, Matthew Wilcox wrote: > It takes a get_block parameter just like nobh_truncate_page() and > block_truncate_page() The patch looks mostly OK. Some minor comments below. > > Signed-off-by: Matthew Wilcox > --- > fs/dax.c | 52 +

[PATCH v7 08/22] Replace xip_truncate_page with dax_truncate_page

2014-03-23 Thread Matthew Wilcox
It takes a get_block parameter just like nobh_truncate_page() and block_truncate_page() Signed-off-by: Matthew Wilcox --- fs/dax.c | 52 fs/ext2/inode.c| 2 +- include/linux/fs.h | 4 ++-- mm/filemap_xip.c | 40 --