Re: [PATCH v7 0/6] rust: extend `module!` macro with integer parameter support

2025-02-27 Thread Miguel Ojeda
On Thu, Feb 27, 2025 at 3:55 PM Petr Pavlu wrote: > > From what I can see in this series, the bindings required adding > a number of generic functions to the Rust support code and also most > discussion revolved around that. I'm worried this might be the case also > for foreseeable future updates,

Re: [PATCH v7 0/6] rust: extend `module!` macro with integer parameter support

2025-02-27 Thread Petr Pavlu
On 2/25/25 12:54, Miguel Ojeda wrote: > On Tue, Feb 25, 2025 at 11:22 AM Petr Pavlu wrote: >> >> I'd say the easiest is for the entire series to go through the Rust >> tree. I'd also propose that any updates go primarily through that tree >> as well. >> >> Makes sense, I think it is useful for all

Re: [PATCH v7 0/6] rust: extend `module!` macro with integer parameter support

2025-02-25 Thread Miguel Ojeda
On Tue, Feb 25, 2025 at 11:22 AM Petr Pavlu wrote: > > I'd say the easiest is for the entire series to go through the Rust > tree. I'd also propose that any updates go primarily through that tree > as well. > > Makes sense, I think it is useful for all changes to this code to be > looked at by bot

Re: [PATCH v7 0/6] rust: extend `module!` macro with integer parameter support

2025-02-25 Thread Petr Pavlu
On 2/24/25 12:27, Andreas Hindborg wrote: > Hi Petr, > > "Andreas Hindborg" writes: > >> This series extends the `module!` macro with support module parameters. It >> also adds some string to integer parsing functions and updates `BStr` with >> a method to strip a string prefix. >> >> This serie

Re: [PATCH v7 0/6] rust: extend `module!` macro with integer parameter support

2025-02-24 Thread Andreas Hindborg
Hi Petr, "Andreas Hindborg" writes: > This series extends the `module!` macro with support module parameters. It > also adds some string to integer parsing functions and updates `BStr` with > a method to strip a string prefix. > > This series stated out as code by Adam Bratschi-Kaye lifted from

Re: [PATCH v7 0/6] rust: extend `module!` macro with integer parameter support

2025-02-22 Thread Andreas Hindborg
"Daniel Almeida" writes: > Hi Andreas, > >> On 18 Feb 2025, at 10:00, Andreas Hindborg wrote: >> >> This series extends the `module!` macro with support module parameters. It >> also adds some string to integer parsing functions and updates `BStr` with >> a method to strip a string prefix. >> >>

Re: [PATCH v7 0/6] rust: extend `module!` macro with integer parameter support

2025-02-21 Thread Daniel Almeida
Hi Andreas, > On 18 Feb 2025, at 10:00, Andreas Hindborg wrote: > > This series extends the `module!` macro with support module parameters. It > also adds some string to integer parsing functions and updates `BStr` with > a method to strip a string prefix. > > This series stated out as code by

[PATCH v7 0/6] rust: extend `module!` macro with integer parameter support

2025-02-18 Thread Andreas Hindborg
This series extends the `module!` macro with support module parameters. It also adds some string to integer parsing functions and updates `BStr` with a method to strip a string prefix. This series stated out as code by Adam Bratschi-Kaye lifted from the original `rust` branch [1]. After a bit of