Re: [PATCH v6 4/5] PCI: only return true when dev io state is really changed

2020-10-03 Thread Ethan Zhao
Bjorn, On Sat, Oct 3, 2020 at 1:29 AM Bjorn Helgaas wrote: > > [+cc Sinan] > > On Wed, Sep 30, 2020 at 03:05:36AM -0400, Ethan Zhao wrote: > > When uncorrectable error happens, AER driver and DPC driver interrupt > > handlers likely call > > > >pcie_do_recovery() > >->pci_walk_bus() > >

Re: [PATCH v6 4/5] PCI: only return true when dev io state is really changed

2020-10-02 Thread Ethan Zhao
Sinan, On Sat, Oct 3, 2020 at 12:08 AM Sinan Kaya wrote: > > On 9/30/2020 3:05 AM, Ethan Zhao wrote: > > When uncorrectable error happens, AER driver and DPC driver interrupt > > handlers likely call > > > >pcie_do_recovery() > >->pci_walk_bus() > > ->report_frozen_detected() > > > >

Re: [PATCH v6 4/5] PCI: only return true when dev io state is really changed

2020-10-02 Thread Bjorn Helgaas
[+cc Sinan] On Wed, Sep 30, 2020 at 03:05:36AM -0400, Ethan Zhao wrote: > When uncorrectable error happens, AER driver and DPC driver interrupt > handlers likely call > >pcie_do_recovery() >->pci_walk_bus() > ->report_frozen_detected() > > with pci_channel_io_frozen the same time. >

Re: [PATCH v6 4/5] PCI: only return true when dev io state is really changed

2020-10-02 Thread Sinan Kaya
On 9/30/2020 3:05 AM, Ethan Zhao wrote: > When uncorrectable error happens, AER driver and DPC driver interrupt > handlers likely call > >pcie_do_recovery() >->pci_walk_bus() > ->report_frozen_detected() > > with pci_channel_io_frozen the same time. We need some more data on this. I

[PATCH v6 4/5] PCI: only return true when dev io state is really changed

2020-09-30 Thread Ethan Zhao
When uncorrectable error happens, AER driver and DPC driver interrupt handlers likely call pcie_do_recovery() ->pci_walk_bus() ->report_frozen_detected() with pci_channel_io_frozen the same time. If pci_dev_set_io_state() return true even if the original state is pci_channel_io_froz