Re: [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with a static array

2016-11-26 Thread Jarkko Sakkinen
On Fri, Nov 25, 2016 at 12:38:13PM -0700, Jason Gunthorpe wrote: > On Fri, Nov 25, 2016 at 10:08:38AM +0200, Jarkko Sakkinen wrote: > > > > This is no good at this point in the series - we need the ENODEV > > > detection in tpm_chip_register() from the 'Fix handle of missing event > > > log' moved

Re: [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with a static array

2016-11-25 Thread Jason Gunthorpe
On Fri, Nov 25, 2016 at 10:08:38AM +0200, Jarkko Sakkinen wrote: > > This is no good at this point in the series - we need the ENODEV > > detection in tpm_chip_register() from the 'Fix handle of missing event > > log' moved into this patch, because it now returns ENODEV due to > > sercurityfs > >

Re: [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with a static array

2016-11-25 Thread Jarkko Sakkinen
On Thu, Nov 24, 2016 at 09:53:13AM -0700, Jason Gunthorpe wrote: > On Thu, Nov 24, 2016 at 03:57:23PM +0200, Jarkko Sakkinen wrote: > > I manually added the changes to: > > > > tpm: replace dynamically allocated bios_dir with a static array > > For this patch.. > > Could drop 'int rc' from tpm

Re: [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with a static array

2016-11-24 Thread Jason Gunthorpe
On Thu, Nov 24, 2016 at 03:57:23PM +0200, Jarkko Sakkinen wrote: > I manually added the changes to: > > tpm: replace dynamically allocated bios_dir with a static array For this patch.. Could drop 'int rc' from tpm1_chip_register, but it will come back in a later patch Could dump TPM_NUM_EVENT

Re: [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with a static array

2016-11-24 Thread Jarkko Sakkinen
On Wed, Nov 23, 2016 at 12:56:19AM +0530, Nayna wrote: > > > On 11/22/2016 04:53 PM, Jarkko Sakkinen wrote: > > On Mon, Nov 14, 2016 at 05:00:50AM -0500, Nayna Jain wrote: > > > This commit is based on a commit by Nayna Jain. Replaced dynamically > > > allocated bios_dir with a static array as th

Re: [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with a static array

2016-11-24 Thread Jarkko Sakkinen
On Tue, Nov 22, 2016 at 09:58:56AM -0700, Jason Gunthorpe wrote: > On Tue, Nov 22, 2016 at 01:23:33PM +0200, Jarkko Sakkinen wrote: > > On Mon, Nov 14, 2016 at 05:00:50AM -0500, Nayna Jain wrote: > > > This commit is based on a commit by Nayna Jain. Replaced dynamically > > > allocated bios_dir wit

Re: [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with a static array

2016-11-22 Thread Nayna
On 11/22/2016 04:53 PM, Jarkko Sakkinen wrote: On Mon, Nov 14, 2016 at 05:00:50AM -0500, Nayna Jain wrote: This commit is based on a commit by Nayna Jain. Replaced dynamically allocated bios_dir with a static array as the size is always constant. Suggested-by: Jason Gunthorpe Signed-off-by:

Re: [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with a static array

2016-11-22 Thread Jason Gunthorpe
On Tue, Nov 22, 2016 at 01:23:33PM +0200, Jarkko Sakkinen wrote: > On Mon, Nov 14, 2016 at 05:00:50AM -0500, Nayna Jain wrote: > > This commit is based on a commit by Nayna Jain. Replaced dynamically > > allocated bios_dir with a static array as the size is always constant. > > > > Suggested-by: J

Re: [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with a static array

2016-11-22 Thread Jarkko Sakkinen
On Mon, Nov 14, 2016 at 05:00:50AM -0500, Nayna Jain wrote: > This commit is based on a commit by Nayna Jain. Replaced dynamically > allocated bios_dir with a static array as the size is always constant. > > Suggested-by: Jason Gunthorpe > Signed-off-by: Nayna Jain > Signed-off-by: Jarkko Sakkin

[PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with a static array

2016-11-14 Thread Nayna Jain
This commit is based on a commit by Nayna Jain. Replaced dynamically allocated bios_dir with a static array as the size is always constant. Suggested-by: Jason Gunthorpe Signed-off-by: Nayna Jain Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-chip.c | 9 --- drivers/char/tpm/