Re: [PATCH v6 3/5] Asoc:qcom:lpass-cpu:Update dts property read API

2020-09-22 Thread Srinivas Kandagatla
On 22/09/2020 13:53, Rohit Kumar wrote: That's very much specific to reg, it's not true of the use of names in general - Rob mentions cases like interrupts for example. Ofcourse using names suffix for clocks and interrupts has been justified! I don't mind having dependency on reg-names as

Re: [PATCH v6 3/5] Asoc:qcom:lpass-cpu:Update dts property read API

2020-09-22 Thread Rohit Kumar
On 9/22/2020 5:13 PM, Mark Brown wrote: On Tue, Sep 22, 2020 at 12:22:38PM +0100, Srinivas Kandagatla wrote: On 22/09/2020 12:08, Mark Brown wrote: I agree with you on this and I see the point, but Rob had a very different opinion about the reg-names bindings to start with. This topic been dis

Re: [PATCH v6 3/5] Asoc:qcom:lpass-cpu:Update dts property read API

2020-09-22 Thread Mark Brown
On Tue, Sep 22, 2020 at 12:22:38PM +0100, Srinivas Kandagatla wrote: > On 22/09/2020 12:08, Mark Brown wrote: > I agree with you on this and I see the point, but Rob had a very different > opinion about the reg-names bindings to start with. > This topic been discussed in the past with Rob in many

Re: [PATCH v6 3/5] Asoc:qcom:lpass-cpu:Update dts property read API

2020-09-22 Thread Srinivas Kandagatla
On 22/09/2020 12:08, Mark Brown wrote: On 18/09/2020 07:04, Srinivasa Rao Mandadapu wrote: - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "lpass-lpaif"); Index is always preferred over name w.r.t device tree bind

Re: [PATCH v6 3/5] Asoc:qcom:lpass-cpu:Update dts property read API

2020-09-22 Thread Mark Brown
On Mon, Sep 21, 2020 at 10:20:22PM +0100, Srinivas Kandagatla wrote: > On 18/09/2020 07:04, Srinivasa Rao Mandadapu wrote: > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "lpass-lpaif"); > Index is always preferred ove

Re: [PATCH v6 3/5] Asoc:qcom:lpass-cpu:Update dts property read API

2020-09-21 Thread Srinivas Kandagatla
On 18/09/2020 07:04, Srinivasa Rao Mandadapu wrote: From: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Signed-off-by: V Sujith Kumar Reddy --- sound/soc/qcom/lpass-cpu.c | 2 +- sound/soc/qcom/lpass-platform.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --g

[PATCH v6 3/5] Asoc:qcom:lpass-cpu:Update dts property read API

2020-09-17 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Signed-off-by: V Sujith Kumar Reddy --- sound/soc/qcom/lpass-cpu.c | 2 +- sound/soc/qcom/lpass-platform.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c