Re: [PATCH v6 3/4] tracing: Add trace_irqsoff tracepoints

2016-09-14 Thread Thomas Gleixner
Binoy, On Wed, 14 Sep 2016, Binoy Jayan wrote: > On 8 September 2016 at 13:36, Thomas Gleixner wrote: > > On Wed, 7 Sep 2016, Binoy Jayan wrote: > >> This captures only the latencies introduced by disabled irqs and > >> preemption. Additional per process data has to be captured to calculate > >>

Re: [PATCH v6 3/4] tracing: Add trace_irqsoff tracepoints

2016-09-13 Thread Binoy Jayan
Hi Thomas, Sorry for the late reply. I was trying out some way to do it the way you suggested. Tried to talk to Carsten regarding the hrtimer latency patch but was unable to. On 8 September 2016 at 13:36, Thomas Gleixner wrote: > On Wed, 7 Sep 2016, Binoy Jayan wrote: >> This captures only the l

Re: [PATCH v6 3/4] tracing: Add trace_irqsoff tracepoints

2016-09-12 Thread Steven Rostedt
On Thu, 8 Sep 2016 10:06:13 +0200 (CEST) Thomas Gleixner wrote: > > + > > if (preempt_trace() || irq_trace()) > > start_critical_timing(CALLER_ADDR0, CALLER_ADDR1); > > } > > @@ -431,6 +451,9 @@ void stop_critical_timings(void) > > { > > if (preempt_trace() || irq_trace())

Re: [PATCH v6 3/4] tracing: Add trace_irqsoff tracepoints

2016-09-08 Thread Thomas Gleixner
On Wed, 7 Sep 2016, Binoy Jayan wrote: > This captures only the latencies introduced by disabled irqs and > preemption. Additional per process data has to be captured to calculate > the effective latencies introduced for individual processes. And what is the additional per process data and how is

Re: [PATCH v6 3/4] tracing: Add trace_irqsoff tracepoints

2016-09-07 Thread Thomas Gleixner
On Thu, 8 Sep 2016, Daniel Wagner wrote: > On 09/07/2016 06:42 PM, Thomas Gleixner wrote: > > On Wed, 7 Sep 2016, Binoy Jayan wrote: > > > > > This work is based on work by Daniel Wagner. A few tracepoints are added > > > > Interesting. The patch you are referring to was written by Carsten > > Em

Re: [PATCH v6 3/4] tracing: Add trace_irqsoff tracepoints

2016-09-07 Thread Daniel Wagner
On 09/07/2016 06:42 PM, Thomas Gleixner wrote: On Wed, 7 Sep 2016, Binoy Jayan wrote: This work is based on work by Daniel Wagner. A few tracepoints are added Interesting. The patch you are referring to was written by Carsten Emde. Can you please get these attributions right? They want to be

Re: [PATCH v6 3/4] tracing: Add trace_irqsoff tracepoints

2016-09-07 Thread Thomas Gleixner
On Wed, 7 Sep 2016, Binoy Jayan wrote: > This work is based on work by Daniel Wagner. A few tracepoints are added Interesting. The patch you are referring to was written by Carsten Emde. Can you please get these attributions right? They want to be reflected in the Tags and if you did not rewrit

[PATCH v6 3/4] tracing: Add trace_irqsoff tracepoints

2016-09-07 Thread Binoy Jayan
This work is based on work by Daniel Wagner. A few tracepoints are added at the end of the critical section. With the hist trigger in place, the hist trigger plots may be generated, with per-cpu breakdown of events captured. It is based on linux kernel's event infrastructure. The following filter(