Re: [PATCH v6 2/7] fpga: sec-mgr: enable secure updates

2020-12-02 Thread Martin Hundebøll
Hi Russ, On 02/12/2020 00.30, Russ Weight wrote: On 12/1/20 12:47 AM, Martin Hundebøll wrote: Hi Russ, On 01/12/2020 00.54, Russ Weight wrote: Thanks Martin. I'll work on a fix for this. Attached is my in-house fix. // Martin On 11/26/20 6:02 AM, Martin Hundebøll wrote: Hi Russ, I foun

Re: [PATCH v6 2/7] fpga: sec-mgr: enable secure updates

2020-12-01 Thread Russ Weight
On 12/1/20 12:47 AM, Martin Hundebøll wrote: > Hi Russ, > > On 01/12/2020 00.54, Russ Weight wrote: >> Thanks Martin. I'll work on a fix for this. > > Attached is my in-house fix. > > // Martin > >> On 11/26/20 6:02 AM, Martin Hundebøll wrote: >>> Hi Russ, >>> >>> I found another thing while tes

Re: [PATCH v6 2/7] fpga: sec-mgr: enable secure updates

2020-12-01 Thread Martin Hundebøll
Hi Russ, On 01/12/2020 00.54, Russ Weight wrote: Thanks Martin. I'll work on a fix for this. Attached is my in-house fix. // Martin On 11/26/20 6:02 AM, Martin Hundebøll wrote: Hi Russ, I found another thing while testing this... On 06/11/2020 02.09, Russ Weight wrote: +static ssize_

Re: [PATCH v6 2/7] fpga: sec-mgr: enable secure updates

2020-11-30 Thread Russ Weight
Thanks Martin. I'll work on a fix for this. - Russ On 11/26/20 6:02 AM, Martin Hundebøll wrote: > Hi Russ, > > I found another thing while testing this... > > On 06/11/2020 02.09, Russ Weight wrote: > > > >> +static ssize_t filename_store(struct device *dev, struct device_attribute >> *attr, >>

Re: [PATCH v6 2/7] fpga: sec-mgr: enable secure updates

2020-11-26 Thread Martin Hundebøll
Hi Russ, I found another thing while testing this... On 06/11/2020 02.09, Russ Weight wrote: +static ssize_t filename_store(struct device *dev, struct device_attribute *attr, + const char *buf, size_t count) +{ + struct fpga_sec_mgr *smgr = to_sec_mgr(dev);

Re: [PATCH v6 2/7] fpga: sec-mgr: enable secure updates

2020-11-19 Thread Martin Hundebøll
Hi Russ, Just stumbled upon the below when preparing to upstream some Silicom changes On 06/11/2020 02.09, Russ Weight wrote: diff --git a/include/linux/fpga/fpga-sec-mgr.h b/include/linux/fpga/fpga-sec-mgr.h index f85665b79b9d..e03de72134d6 100644 --- a/include/linux/fpga/fpga-sec-mgr.h ++

[PATCH v6 2/7] fpga: sec-mgr: enable secure updates

2020-11-05 Thread Russ Weight
Extend the FPGA Security Manager class driver to include an update/filename sysfs node that can be used to initiate a secure update. The filename of a secure update file (BMC image, FPGA image, Root Entry Hash image, or Code Signing Key cancellation image) can be written to this sysfs entry to cau