RE: Re: [PATCH v6 2/5] scsi: ufs: Add UFS-feature layer

2020-08-04 Thread Daejun Park
Hi Bart, > Any idea how much time this work will take and when a new version will be > posted? I have plan to patch new version in this week. Thanks, Daejun

Re: [PATCH v6 2/5] scsi: ufs: Add UFS-feature layer

2020-08-04 Thread Bart Van Assche
On 2020-07-26 23:18, Daejun Park wrote: >>> I am also not sold on the whole "bus" thing. >> >> How about implementing HPB as a kernel module that calls the functions >> in the UFS core directly, or in other words, get rid completely of the >> new ufsf_bus introduced by this patch? > > OK, I will r

Re: [PATCH v6 2/5] scsi: ufs: Add UFS-feature layer

2020-07-26 Thread Daejun Park
> > I am also not sold on the whole "bus" thing. > > How about implementing HPB as a kernel module that calls the functions > in the UFS core directly, or in other words, get rid completely of the > new ufsf_bus introduced by this patch? OK, I will remove the ufsf_bus and indirect calling functio

Re: [PATCH v6 2/5] scsi: ufs: Add UFS-feature layer

2020-07-22 Thread Bart Van Assche
On 2020-07-22 05:46, Martin K. Petersen wrote: > I am also not sold on the whole "bus" thing. How about implementing HPB as a kernel module that calls the functions in the UFS core directly, or in other words, get rid completely of the new ufsf_bus introduced by this patch? Thanks, Bart.

Re: [PATCH v6 2/5] scsi: ufs: Add UFS-feature layer

2020-07-22 Thread Martin K. Petersen
Christoph, > Independent of the problems with the concept of HPB, this patch is > just really bad software architecture. Don't just add random > indirection layers that do represent an actual real abstraction. I am also not sold on the whole "bus" thing. -- Martin K. Petersen Oracle Lin

Re: [PATCH v6 2/5] scsi: ufs: Add UFS-feature layer

2020-07-21 Thread Christoph Hellwig
On Mon, Jul 13, 2020 at 07:40:40PM +0900, Daejun Park wrote: > This patch is adding UFS feature layer to UFS core driver. > > UFS Driver data structure (struct ufs_hba) Independent of the problems with the concept of HPB, this patch is just really bad software architecture. Don't just add random

[PATCH v6 2/5] scsi: ufs: Add UFS-feature layer

2020-07-13 Thread Daejun Park
This patch is adding UFS feature layer to UFS core driver. UFS Driver data structure (struct ufs_hba) │ ┌--┐ │ UFS feature │ <-- HPB module │layer │ <-- other extended feature module └--┘ Each extended UFS-Feature module has a bus of ufs-ext feature type. T