Re: [PATCH v6 2/4] i2c: add support for Diolan DLN-2 USB-I2C adapter

2014-10-08 Thread Octavian Purdila
On Wed, Oct 8, 2014 at 1:42 PM, Johan Hovold wrote: > On Thu, Sep 25, 2014 at 07:07:32PM +0300, Octavian Purdila wrote: > >> diff --git a/Documentation/ABI/testing/sysfs-bus-i2c-busses-dln2 >> b/Documentation/ABI/testing/sysfs-bus-i2c-busses-dln2 >> new file mode 100644 >> index 000..ad55af6

Re: [PATCH v6 2/4] i2c: add support for Diolan DLN-2 USB-I2C adapter

2014-10-08 Thread Johan Hovold
On Thu, Sep 25, 2014 at 07:07:32PM +0300, Octavian Purdila wrote: > diff --git a/Documentation/ABI/testing/sysfs-bus-i2c-busses-dln2 > b/Documentation/ABI/testing/sysfs-bus-i2c-busses-dln2 > new file mode 100644 > index 000..ad55af6 > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-bus-

Re: [PATCH v6 2/4] i2c: add support for Diolan DLN-2 USB-I2C adapter

2014-10-07 Thread Johan Hovold
On Tue, Oct 07, 2014 at 08:52:35PM +0300, Octavian Purdila wrote: > On Tue, Oct 7, 2014 at 7:46 PM, Johan Hovold wrote: > > On Thu, Sep 25, 2014 at 07:07:32PM +0300, Octavian Purdila wrote: > >> +static DEVICE_ATTR_RW(dln2_i2c_freq); > > > > You forgot to add the required documentation of the att

Re: [PATCH v6 2/4] i2c: add support for Diolan DLN-2 USB-I2C adapter

2014-10-07 Thread Octavian Purdila
On Tue, Oct 7, 2014 at 7:46 PM, Johan Hovold wrote: > On Thu, Sep 25, 2014 at 07:07:32PM +0300, Octavian Purdila wrote: >> From: Laurentiu Palcu >> >> This patch adds support for the Diolan DLN-2 I2C master module. Due >> to hardware limitations it does not support SMBUS quick commands. >> >> Inf

Re: [PATCH v6 2/4] i2c: add support for Diolan DLN-2 USB-I2C adapter

2014-10-07 Thread Johan Hovold
On Thu, Sep 25, 2014 at 07:07:32PM +0300, Octavian Purdila wrote: > From: Laurentiu Palcu > > This patch adds support for the Diolan DLN-2 I2C master module. Due > to hardware limitations it does not support SMBUS quick commands. > > Information about the USB protocol interface can be found in t

Re: [PATCH v6 2/4] i2c: add support for Diolan DLN-2 USB-I2C adapter

2014-10-03 Thread Octavian Purdila
On Fri, Oct 3, 2014 at 4:14 AM, Wolfram Sang wrote: > Hi, > >> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig >> index 2ac87fa..6afc17e 100644 >> --- a/drivers/i2c/busses/Kconfig >> +++ b/drivers/i2c/busses/Kconfig >> @@ -1021,4 +1021,14 @@ config SCx200_ACB >> This s

Re: [PATCH v6 2/4] i2c: add support for Diolan DLN-2 USB-I2C adapter

2014-10-02 Thread Wolfram Sang
Hi, > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index 2ac87fa..6afc17e 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -1021,4 +1021,14 @@ config SCx200_ACB > This support is also available as a module. If so, the module >

[PATCH v6 2/4] i2c: add support for Diolan DLN-2 USB-I2C adapter

2014-09-25 Thread Octavian Purdila
From: Laurentiu Palcu This patch adds support for the Diolan DLN-2 I2C master module. Due to hardware limitations it does not support SMBUS quick commands. Information about the USB protocol interface can be found in the Programmer's Reference Manual [1], see section 6.2.2 for the I2C master mod