Re: [PATCH v6 2/3] media: ov8856: Add devicetree support

2020-05-03 Thread Marco Felsch
Hi Robert, On 20-04-30 18:11, Robert Foss wrote: > Hey Marco, > > On Thu, 30 Apr 2020 at 14:07, Marco Felsch wrote: > > > > On 20-04-30 13:20, Sakari Ailus wrote: > > > On Thu, Apr 30, 2020 at 12:11:57PM +0200, Marco Felsch wrote: > > > > On 20-04-30 12:59, Sakari Ailus wrote: > > > > > Hi Marco

Re: [PATCH v6 2/3] media: ov8856: Add devicetree support

2020-04-30 Thread Robert Foss
Hey Marco, On Thu, 30 Apr 2020 at 14:07, Marco Felsch wrote: > > On 20-04-30 13:20, Sakari Ailus wrote: > > On Thu, Apr 30, 2020 at 12:11:57PM +0200, Marco Felsch wrote: > > > On 20-04-30 12:59, Sakari Ailus wrote: > > > > Hi Marco, > > > > > > > > On Thu, Apr 30, 2020 at 11:53:32AM +0200, Marco

Re: [PATCH v6 2/3] media: ov8856: Add devicetree support

2020-04-30 Thread Sakari Ailus
On Thu, Apr 30, 2020 at 02:07:41PM +0200, Marco Felsch wrote: > On 20-04-30 13:20, Sakari Ailus wrote: > > On Thu, Apr 30, 2020 at 12:11:57PM +0200, Marco Felsch wrote: > > > On 20-04-30 12:59, Sakari Ailus wrote: > > > > Hi Marco, > > > > > > > > On Thu, Apr 30, 2020 at 11:53:32AM +0200, Marco Fe

Re: [PATCH v6 2/3] media: ov8856: Add devicetree support

2020-04-30 Thread Marco Felsch
On 20-04-30 13:20, Sakari Ailus wrote: > On Thu, Apr 30, 2020 at 12:11:57PM +0200, Marco Felsch wrote: > > On 20-04-30 12:59, Sakari Ailus wrote: > > > Hi Marco, > > > > > > On Thu, Apr 30, 2020 at 11:53:32AM +0200, Marco Felsch wrote: > > > > Hi Sakari, > > > > > > > > On 20-04-30 12:45, Sakari

Re: [PATCH v6 2/3] media: ov8856: Add devicetree support

2020-04-30 Thread Sakari Ailus
On Thu, Apr 30, 2020 at 12:11:57PM +0200, Marco Felsch wrote: > On 20-04-30 12:59, Sakari Ailus wrote: > > Hi Marco, > > > > On Thu, Apr 30, 2020 at 11:53:32AM +0200, Marco Felsch wrote: > > > Hi Sakari, > > > > > > On 20-04-30 12:45, Sakari Ailus wrote: > > > > Hi Marco, > > > > > > > > On Thu,

Re: [PATCH v6 2/3] media: ov8856: Add devicetree support

2020-04-30 Thread Marco Felsch
On 20-04-30 12:59, Sakari Ailus wrote: > Hi Marco, > > On Thu, Apr 30, 2020 at 11:53:32AM +0200, Marco Felsch wrote: > > Hi Sakari, > > > > On 20-04-30 12:45, Sakari Ailus wrote: > > > Hi Marco, > > > > > > On Thu, Apr 30, 2020 at 11:35:24AM +0200, Marco Felsch wrote: ... > > > > > - if (m

Re: [PATCH v6 2/3] media: ov8856: Add devicetree support

2020-04-30 Thread Sakari Ailus
Hi Marco, On Thu, Apr 30, 2020 at 11:53:32AM +0200, Marco Felsch wrote: > Hi Sakari, > > On 20-04-30 12:45, Sakari Ailus wrote: > > Hi Marco, > > > > On Thu, Apr 30, 2020 at 11:35:24AM +0200, Marco Felsch wrote: > > > Hi Robert, > > > > > > thnakf for the patch but pls keep in mind to do one th

Re: [PATCH v6 2/3] media: ov8856: Add devicetree support

2020-04-30 Thread Marco Felsch
Hi Sakari, On 20-04-30 12:45, Sakari Ailus wrote: > Hi Marco, > > On Thu, Apr 30, 2020 at 11:35:24AM +0200, Marco Felsch wrote: > > Hi Robert, > > > > thnakf for the patch but pls keep in mind to do one thing per patch. > > IMHO this patch do a lot more. Anyway below are my comment :) > > > > O

Re: [PATCH v6 2/3] media: ov8856: Add devicetree support

2020-04-30 Thread Sakari Ailus
Hi Marco, On Thu, Apr 30, 2020 at 11:35:24AM +0200, Marco Felsch wrote: > Hi Robert, > > thnakf for the patch but pls keep in mind to do one thing per patch. > IMHO this patch do a lot more. Anyway below are my comment :) > > On 20-04-29 18:24, Robert Foss wrote: > > Add match table, enable ov88

Re: [PATCH v6 2/3] media: ov8856: Add devicetree support

2020-04-30 Thread Marco Felsch
Hi Robert, thnakf for the patch but pls keep in mind to do one thing per patch. IMHO this patch do a lot more. Anyway below are my comment :) On 20-04-29 18:24, Robert Foss wrote: > Add match table, enable ov8856_probe() to support > both ACPI and DT modes. You are also adding the support for re

[PATCH v6 2/3] media: ov8856: Add devicetree support

2020-04-29 Thread Robert Foss
Add match table, enable ov8856_probe() to support both ACPI and DT modes. ACPI and DT modes are primarily distinguished from each other by relying on devm_XXX_get_optional() will return NULL instead of a reference for the desired managed resource. Signed-off-by: Robert Foss --- - Changes since