Re: [PATCH v6 12/12] mmap locking API: convert mmap_sem comments

2020-05-29 Thread Daniel Jordan
On Tue, May 19, 2020 at 10:29:08PM -0700, Michel Lespinasse wrote: > Convert comments that reference mmap_sem to reference mmap_lock instead. > > Signed-off-by: Michel Lespinasse Not opposed to leaving lockaphores in :) Reviewed-by: Daniel Jordan

Re: [PATCH v6 12/12] mmap locking API: convert mmap_sem comments

2020-05-22 Thread Vlastimil Babka
On 5/21/20 7:25 PM, Andrew Morton wrote: > On Thu, 21 May 2020 00:50:56 -0700 Michel Lespinasse > wrote: > >> > > * Must be called holding task's alloc_lock to protect task's >> > > mems_allowed >> > > - * and mempolicy. May also be called holding the mmap_semaphore for >> > > write. >> > >

Re: [PATCH v6 12/12] mmap locking API: convert mmap_sem comments

2020-05-21 Thread Andrew Morton
On Thu, 21 May 2020 00:50:56 -0700 Michel Lespinasse wrote: > > > * Must be called holding task's alloc_lock to protect task's > > > mems_allowed > > > - * and mempolicy. May also be called holding the mmap_semaphore for > > > write. > > > + * and mempolicy. May also be called holding the m

Re: [PATCH v6 12/12] mmap locking API: convert mmap_sem comments

2020-05-21 Thread Michel Lespinasse
On Thu, May 21, 2020 at 12:42 AM Vlastimil Babka wrote: > On 5/20/20 7:29 AM, Michel Lespinasse wrote: > > Convert comments that reference mmap_sem to reference mmap_lock instead. > > > > Signed-off-by: Michel Lespinasse > > Reviewed-by: Vlastimil Babka > > But: > > > diff --git a/mm/mempolicy.c

Re: [PATCH v6 12/12] mmap locking API: convert mmap_sem comments

2020-05-21 Thread Vlastimil Babka
On 5/20/20 7:29 AM, Michel Lespinasse wrote: > Convert comments that reference mmap_sem to reference mmap_lock instead. > > Signed-off-by: Michel Lespinasse Reviewed-by: Vlastimil Babka But: > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index a1247d3553da..1bf46e2e0cec 100644 > --- a/mm/me

Re: [PATCH v6 12/12] mmap locking API: convert mmap_sem comments

2020-05-20 Thread Michel Lespinasse
Looks good, thanks ! On Wed, May 20, 2020 at 8:22 PM Andrew Morton wrote: > On Tue, 19 May 2020 22:29:08 -0700 Michel Lespinasse > wrote: > > Convert comments that reference mmap_sem to reference mmap_lock instead. > > This may not be complete.. > > From: Andrew Morton > Subject: mmap-locking-

Re: [PATCH v6 12/12] mmap locking API: convert mmap_sem comments

2020-05-20 Thread Andrew Morton
On Tue, 19 May 2020 22:29:08 -0700 Michel Lespinasse wrote: > Convert comments that reference mmap_sem to reference mmap_lock instead. This may not be complete.. From: Andrew Morton Subject: mmap-locking-api-convert-mmap_sem-comments-fix fix up linux-next leftovers Cc: Daniel Jordan Cc: Dav

[PATCH v6 12/12] mmap locking API: convert mmap_sem comments

2020-05-19 Thread Michel Lespinasse
Convert comments that reference mmap_sem to reference mmap_lock instead. Signed-off-by: Michel Lespinasse --- .../admin-guide/mm/numa_memory_policy.rst | 10 ++--- Documentation/admin-guide/mm/userfaultfd.rst | 2 +- Documentation/filesystems/locking.rst | 2 +- Documentation/vm/t