Re: [PATCH v6 11/13] block: Rework bio_pair_split()

2012-08-24 Thread Tejun Heo
Hello, Martin. On Thu, Aug 23, 2012 at 10:25:47PM -0400, Martin K. Petersen wrote: > However, I'm not sure I like the overall approach of the new splitting. > Instead of all this cloning, slicing and dicing of bio_vecs I'd rather > we bit the bullet and had an offset + length for the vector inside

Re: [PATCH v6 11/13] block: Rework bio_pair_split()

2012-08-24 Thread Tejun Heo
Hello, On Fri, Aug 24, 2012 at 03:30:49AM -0700, Kent Overstreet wrote: > > I complained about this in the last posting and in the previous patch. > > Please respond. Martin, are you okay with these integrity changes? > > I did respond. I said more before, but in short the old > bio_integrity_sp

Re: [PATCH v6 11/13] block: Rework bio_pair_split()

2012-08-24 Thread Kent Overstreet
On Thu, Aug 23, 2012 at 10:25:47PM -0400, Martin K. Petersen wrote: > > "Tejun" == Tejun Heo writes: > > Tejun> I complained about this in the last posting and in the previous > Tejun> patch. Please respond. Martin, are you okay with these > Tejun> integrity changes? > > I missed the first

Re: [PATCH v6 11/13] block: Rework bio_pair_split()

2012-08-24 Thread Kent Overstreet
On Wed, Aug 22, 2012 at 02:04:10PM -0700, Tejun Heo wrote: > Hello, Kent. > > On Wed, Aug 22, 2012 at 10:04:08AM -0700, Kent Overstreet wrote: > > This changes bio_pair_split() to use the new bio_split() underneath, > > which gets rid of the single page bio limitation. The various callers > > are

Re: [PATCH v6 11/13] block: Rework bio_pair_split()

2012-08-23 Thread Martin K. Petersen
> "Tejun" == Tejun Heo writes: Tejun> I complained about this in the last posting and in the previous Tejun> patch. Please respond. Martin, are you okay with these Tejun> integrity changes? I missed the first several iterations of all this while I was out on vacation. I'll have to try to w

Re: [PATCH v6 11/13] block: Rework bio_pair_split()

2012-08-22 Thread Tejun Heo
Hello, Kent. On Wed, Aug 22, 2012 at 10:04:08AM -0700, Kent Overstreet wrote: > This changes bio_pair_split() to use the new bio_split() underneath, > which gets rid of the single page bio limitation. The various callers > are fixed up for the slightly different struct bio_pair, and to remove > th

[PATCH v6 11/13] block: Rework bio_pair_split()

2012-08-22 Thread Kent Overstreet
This changes bio_pair_split() to use the new bio_split() underneath, which gets rid of the single page bio limitation. The various callers are fixed up for the slightly different struct bio_pair, and to remove the unnecessary checks. v5: Move extern declaration to proper patch, per Boaz Signed-of