Re: [PATCH v6 10/19] i2c: octeon: Add support for cn78xx chips

2016-04-25 Thread Wolfram Sang
> Personally, I preferred the old way where each device had interrupt enable > bits that could be controlled independently of the interrupt controller. I > have been told that I should abandon my preference for that type of > antiquated architecture and welcome the brave new world of the unified

Re: [PATCH v6 10/19] i2c: octeon: Add support for cn78xx chips

2016-04-20 Thread David Daney
On 04/20/2016 02:52 PM, Wolfram Sang wrote: On Mon, Apr 11, 2016 at 05:28:41PM +0200, Jan Glauber wrote: From: David Daney cn78xx has a different interrupt architecture, so we have to manage the interrupts differently. I'd appreciate if you could explain here why interrupts use NOAUTOEN and

Re: [PATCH v6 10/19] i2c: octeon: Add support for cn78xx chips

2016-04-20 Thread Wolfram Sang
On Mon, Apr 11, 2016 at 05:28:41PM +0200, Jan Glauber wrote: > From: David Daney > > cn78xx has a different interrupt architecture, so we have to manage > the interrupts differently. I'd appreciate if you could explain here why interrupts use NOAUTOEN and have to be manually en-/disabled? This i

[PATCH v6 10/19] i2c: octeon: Add support for cn78xx chips

2016-04-11 Thread Jan Glauber
From: David Daney cn78xx has a different interrupt architecture, so we have to manage the interrupts differently. Signed-off-by: David Daney Signed-off-by: Jan Glauber --- drivers/i2c/busses/i2c-octeon.c | 131 1 file changed, 120 insertions(+), 11 del