Re: [PATCH v6 1/9] w1_therm: adding code comments and code reordering

2020-05-11 Thread Akira shimahara
Hi, Le dimanche 10 mai 2020 à 20:33 -0700, Randy Dunlap a écrit : > Hi, > > A few more comments here (inline): > > On 5/10/20 7:15 AM, Akira Shimahara wrote: > > > drivers/w1/slaves/w1_therm.c | 398 --- > > 1 file changed, 232 insertions(+), 166 deletions(-) >

Re: [PATCH v6 1/9] w1_therm: adding code comments and code reordering

2020-05-10 Thread Randy Dunlap
Hi, A few more comments here (inline): On 5/10/20 7:15 AM, Akira Shimahara wrote: > drivers/w1/slaves/w1_therm.c | 398 --- > 1 file changed, 232 insertions(+), 166 deletions(-) > > diff --git a/drivers/w1/slaves/w1_therm.c b/drivers/w1/slaves/w1_therm.c > index

[PATCH v6 1/9] w1_therm: adding code comments and code reordering

2020-05-10 Thread Akira Shimahara
Adding code comments to split code in dedicated parts. After the global declarations (defines, macros and function declarations), code is organized as follow : - Device and family dependent structures and functions - Interfaces functions - Helpers functions - Hardware functions - Sysfs interfa