Re: [PATCH v6 1/3] spi/pl022: Add chip select handling via GPIO

2012-09-03 Thread Linus Walleij
On Sun, Sep 2, 2012 at 3:12 PM, shiraz hashim wrote: > Hi Linus, >> Yes that is why the allocation looks like this: >> >> + master = spi_alloc_master(dev, sizeof(struct pl022) + sizeof(int) * >> + platform_info->num_chipselect); >> > > The allocation is such

Re: [PATCH v6 1/3] spi/pl022: Add chip select handling via GPIO

2012-09-02 Thread Roland Stigge
Hi Shiraz, On 01/09/12 13:14, shiraz hashim wrote: > On Wed, Aug 22, 2012 at 7:19 PM, Roland Stigge wrote: >> @@ -2016,6 +2030,8 @@ pl022_probe(struct amba_device *adev, co >> pl022->master_info = platform_info; >> pl022->adev = adev; >> pl022->vendor = id->data; >> +

Re: [PATCH v6 1/3] spi/pl022: Add chip select handling via GPIO

2012-09-02 Thread shiraz hashim
Hi Linus, On Sun, Sep 2, 2012 at 12:48 PM, Linus Walleij wrote: > On Sat, Sep 1, 2012 at 1:14 PM, shiraz hashim > wrote: >> Hi Roland, >> >> On Wed, Aug 22, 2012 at 7:19 PM, Roland Stigge wrote: >>> @@ -2016,6 +2030,8 @@ pl022_probe(struct amba_device *adev, co >>> pl022->master_info =

Re: [PATCH v6 1/3] spi/pl022: Add chip select handling via GPIO

2012-09-02 Thread Linus Walleij
On Sat, Sep 1, 2012 at 1:14 PM, shiraz hashim wrote: > Hi Roland, > > On Wed, Aug 22, 2012 at 7:19 PM, Roland Stigge wrote: >> @@ -2016,6 +2030,8 @@ pl022_probe(struct amba_device *adev, co >> pl022->master_info = platform_info; >> pl022->adev = adev; >> pl022->vendor = id

Re: [PATCH v6 1/3] spi/pl022: Add chip select handling via GPIO

2012-09-01 Thread shiraz hashim
Hi Roland, On Wed, Aug 22, 2012 at 7:19 PM, Roland Stigge wrote: > @@ -2016,6 +2030,8 @@ pl022_probe(struct amba_device *adev, co > pl022->master_info = platform_info; > pl022->adev = adev; > pl022->vendor = id->data; > + /* Point chipselects to allocated memory beyo

Re: [PATCH v6 1/3] spi/pl022: Add chip select handling via GPIO

2012-08-22 Thread Linus Walleij
On Wed, Aug 22, 2012 at 3:49 PM, Roland Stigge wrote: > This patch adds the ability for the driver to control the chip select > directly. > This enables independence from cs_control callbacks. Configurable via > platform_data, to be extended as DT in the following patch. > > Based on the initia

[PATCH v6 1/3] spi/pl022: Add chip select handling via GPIO

2012-08-22 Thread Roland Stigge
This patch adds the ability for the driver to control the chip select directly. This enables independence from cs_control callbacks. Configurable via platform_data, to be extended as DT in the following patch. Based on the initial patch by Alexandre Pereira da Silva Signed-off-by: Roland Stigge